perf(EPv2): update EPv2 combine tune config#500
Open
kawhil-amd wants to merge 4 commits into
Open
Conversation
…irectly Replace the two-phase comb_bar inter-block signaling chain with direct xdb_mem spinning from all blocks. Removes atomic counting, final cleanup spin, and reduces Stage 1 barrier code from ~30 lines to ~14 lines. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The epoch bump is the only thing advancing xdb_flag; without it the second combine invocation sees stale xdb_mem == xdb_cur_flag and the entry barrier becomes a no-op, reading unready data. Place the bump after fx.barrier() so all blocks have consumed xdb_cur_flag first. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Gather combine reads from remote peer memory via xGMI (uncached); no local L2 stale entries to invalidate. The original code never had this fence — it was incorrectly added during the comb_bar elimination. Co-Authored-By: Claude Opus 4.6 <[email protected]>
kawhil-amd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.