.github/scripts: add --retry-ignored-tests switch to test_rocgdb.py#208
Merged
Merged
Conversation
By default, tests on the ignore list that fail on the first run are now skipped on subsequent retry iterations. This avoids re-running known-bad tests (especially slow ones that time out) across multiple iterations and two compiler runs, keeping wall-clock time reasonable. Pass --retry-ignored-tests to restore the previous behaviour of retrying every failing test regardless of ignore-list membership. Co-Authored-By: Claude <[email protected]>
lumachad
force-pushed
the
users/amd-staging/retry-ignored-tests
branch
from
74b3640 to
ec7b606
Compare
lumachad
changed the title
aktemur
reviewed
Jul 15, 2026
aktemur
left a comment
aktemur
left a comment
Contributor
There was a problem hiding this comment.
I don't know this CI Python script much, but the patch looked reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tests on the ignore list are known to fail. When they fail (e.g. with a
timeout), the current retry logic re-runs them up to
--max-failed-retriestimes for each of the two compiler runs, adding significant wall-clock time
for no diagnostic value.
Technical Details
Add a
--retry-ignored-testsswitch totest_rocgdb.py(default: off).When off (the default), any test that appears in the ignore list
(
rocgdb_ignore_list.json) and fails on the first run is excluded fromsubsequent retry iterations. If all remaining failures are on the ignore
list, iterations stop early. Skipped tests are logged with a note pointing
to
--retry-ignored-tests.When
--retry-ignored-testsis passed (or--no-xfailis active), theprevious behaviour is preserved: every failing test is retried regardless of
ignore-list membership.
The new flag is shown in the configuration summary printed at the start of
each run.
Test Plan
--retry-ignored-testsand--no-xfailboth bypass thefilter correctly.
Test Result
N/A (CI-script change only; no GPU hardware required to validate the logic).
Submission Checklist