handle clusters#206
Open
aktemur wants to merge 2 commits into
Open
Conversation
The function 'amdgpu_used_lanes_count' in amdgpu-tdep.c and the function 'lane_workgroup_pos' in amd-dbgapi-target.c both compute partial workgroup sizes the same way. Extract the common code into a function named 'partial_workgroup_sizes' and reuse. This is a refactoring with no behavioral change.
Starting with gfx1250, workgroups may be organized into clusters, giving a workitem -> wave -> workgroup -> cluster -> grid hierarchy. Handle clusters by taking them into account when calculating workitem/lane coordinates, when showing wave target ids, and in the "info dispatches" command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
New feature: workgroup clusters
Technical Details
Workgroups can be organized in clusters. dbgapi provides new query functions. Use these queries to show cluster information.
Test Plan
A basic test is included.