Skip to content

Update Tile op builder to work with dynamic inputs#5069

Open
turneram wants to merge 16 commits into
developfrom
dynamic-tile-op-builder
Open

Update Tile op builder to work with dynamic inputs#5069
turneram wants to merge 16 commits into
developfrom
dynamic-tile-op-builder

Conversation

@turneram

Copy link
Copy Markdown
Contributor

Motivation

Required changes to support dynamic kv-cache as it appears in specific model.

Technical Details

Adds path to tile's op builder to handle dynamic inputs, and updates downstream ops (multibroadcast, reshape(_lazy), and unsqueeze) to handle them correctly.

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

Follow the LLVM AI Tool Use Policy for contributions using AI.

@turneram
turneram requested a review from causten as a code owner July 15, 2026 18:17
Format

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5069      +/-   ##
===========================================
+ Coverage    92.90%   92.93%   +0.03%     
===========================================
  Files          603      603              
  Lines        32526    32624      +98     
===========================================
+ Hits         30217    30318     +101     
+ Misses        2309     2306       -3     
Files with missing lines Coverage Δ
src/include/migraphx/op/multibroadcast.hpp 98.33% <100.00%> (+0.83%) ⬆️
src/include/migraphx/op/reshape.hpp 100.00% <100.00%> (+1.19%) ⬆️
src/include/migraphx/op/reshape_lazy.hpp 100.00% <100.00%> (+3.08%) ⬆️
src/op/builder/tile.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gh-app-migraphx-bot-pr-write

gh-app-migraphx-bot-pr-write Bot commented Jul 16, 2026

Copy link
Copy Markdown
Test Batch New Rate (3b891a) Old Rate (6b283c)* Diff Status
torchvision-resnet50 64 3,280.20 3,286.50 -0.19%
torchvision-resnet50_fp16 64 7,616.48 7,625.35 -0.12%
torchvision-densenet121 32 2,245.72 2,504.05 -10.32% 🔴
torchvision-densenet121_fp16 32 4,979.92 5,012.36 -0.65%
torchvision-inceptionv3 32 2,068.00 2,064.70 0.16%
torchvision-inceptionv3_fp16 32 448.80 4,431.92 -89.87% 🔴
cadene-inceptionv4 16 163.62 822.36 -80.10% 🔴
cadene-resnext64x4 16 252.21 785.61 -67.90% 🔴
slim-mobilenet 64 8,422.46 8,421.44 0.01%
slim-nasnetalarge 64 84.29 230.76 -63.47% 🔴
slim-resnet50v2 64 863.19 3,209.40 -73.10% 🔴
bert-mrpc-onnx 8 81.28 1,166.49 -93.03% 🔴
bert-mrpc-tf 1 12.06 488.00 -97.53% 🔴
pytorch-examples-wlang-gru 1 481.37 472.76 1.82%
pytorch-examples-wlang-lstm 1 418.54 437.48 -4.33%
torchvision-resnet50_1 1 155.39 1,029.11 -84.90% 🔴
cadene-dpn92_1 1 479.20 446.31 7.37% 🔆
cadene-resnext101_1 1 363.71 365.47 -0.48%
onnx-taau-downsample 1 845.75 850.19 -0.52%
dlrm-criteoterabyte 1 1.07 32.58 -96.70% 🔴
dlrm-criteoterabyte_fp16 1 36.73 52.90 -30.57% 🔴
agentmodel 1 3,348.03 8,883.83 -62.31% 🔴
unet_fp16 2 23.97 59.21 -59.52% 🔴
resnet50v1_fp16 1 266.59 1,393.35 -80.87% 🔴
resnet50v1_int8 1 1,672.68 1,897.46 -11.85% 🔴
bert_base_cased_fp16 64 788.93 1,106.24 -28.68% 🔴
bert_large_uncased_fp16 32 347.33 346.58 0.22%
bert_large_fp16 1 207.30 207.25 0.02%
distilgpt2_fp16 16 2,105.98 2,105.76 0.01%
yolov5s 1 561.51 564.86 -0.59%
tinyllama 1 41.93 45.89 -8.62% 🔴
vicuna-fastchat 1 15.34 44.03 -65.17% 🔴
whisper-tiny-encoder 1 415.42 415.29 0.03%
whisper-tiny-decoder 1 408.99 412.90 -0.95%
llama2_7b 1 20.95 21.00 -0.23%
qwen1.5-7b 1 4.13 23.61 -82.52% 🔴
phi3-3.8b 1 5.41 16.42 -67.09% 🔴
llama3-8b 1 21.70 21.28 1.99%
whisper-large-encoder 1 10.24 10.25 -0.06%
whisper-large-decoder 1 107.40 107.21 0.18%
mistral-7b 1 23.75 23.59 0.68%
FLUX.1-schnell 1 800.95 252.31 217.45% 🔆

Regressions detected 🔴

* No develop baseline was found for this PR's branch point; compared against the latest available develop run instead.

@gh-app-migraphx-bot-pr-write

gh-app-migraphx-bot-pr-write Bot commented Jul 16, 2026

Copy link
Copy Markdown
Test Status Result
bert-mrpc-onnx PASSED: MIGraphX meets tolerance
bert-mrpc-tf PASSED: MIGraphX meets tolerance
pytorch-examples-wlang-gru PASSED: MIGraphX meets tolerance
pytorch-examples-wlang-lstm PASSED: MIGraphX meets tolerance
dlrm-criteoterabyte PASSED: MIGraphX meets tolerance
agentmodel PASSED: MIGraphX meets tolerance
unet PASSED: MIGraphX meets tolerance
resnet50v1 PASSED: MIGraphX meets tolerance
bert_base_cased_fp16 PASSED: MIGraphX meets tolerance
bert_large_uncased_fp16 🔴 FAILED: MIGraphX is not within tolerance - check verbose output
bert_large PASSED: MIGraphX meets tolerance
yolov5s PASSED: MIGraphX meets tolerance
tinyllama PASSED: MIGraphX meets tolerance
vicuna-fastchat PASSED: MIGraphX meets tolerance
whisper-tiny-encoder PASSED: MIGraphX meets tolerance
whisper-tiny-decoder PASSED: MIGraphX meets tolerance
distilgpt2_fp16 PASSED: MIGraphX meets tolerance
llama2_7b PASSED: MIGraphX meets tolerance
qwen1.5-7b PASSED: MIGraphX meets tolerance
phi3-3.8b PASSED: MIGraphX meets tolerance
llama3-8b PASSED: MIGraphX meets tolerance
whisper-large-encoder PASSED: MIGraphX meets tolerance
whisper-large-decoder PASSED: MIGraphX meets tolerance
mistral-7b PASSED: MIGraphX meets tolerance
FLUX.1-schnell PASSED: MIGraphX meets tolerance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant