Fix security_gate workflow semantics for blocked external PRs#5041
Draft
danieyan-amd with Copilot wants to merge 2 commits into
Draft
Fix security_gate workflow semantics for blocked external PRs#5041danieyan-amd with Copilot wants to merge 2 commits into
security_gate workflow semantics for blocked external PRs#5041danieyan-amd with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job security_gate
Fix Jul 7, 2026
security_gate workflow semantics for blocked external PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
security_gatejob in the performance workflow was failing for expected blocked states on external PRs. This made the workflow report a failure even when the intended outcome was simply “do not run performance jobs until a maintainer re-approves testing”.Technical Details
Gate behavior
is_ok_to_test=falseand exiting successfully.needs.security_gate.outputs.is_ok_to_test == 'true'.Synchronize handling
pull_request.synchronizebefore label validation.ok-to-test, emit a warning, and stop further execution without failing the job.Missing approval handling
ok-to-testwith a notice-level block.Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable