Add std C++ components to rocm namespace and add unit tests

CMakeLists.txt

@@ -353,6 +353,8 @@ rocm_enable_cppcheck(
         # Disable because of too many FPs
         arithOperationsOnVoidPointer
         definePrefix:*test/include/test.hpp
+        definePrefix:*test/gpu/kernels/rocm*
+        definePrefix:*src/targets/gpu/kernels/include/rocm*
         definePrefix:*src/targets/gpu/kernels/include/migraphx/kernels/test.hpp
         # test/pp.cpp exercises the MIGRAPHX_PP_* metaprogramming macros directly, which
         # cppcheck's preprocessor cannot expand.

src/compile_src.cpp

@@ -1,7 +1,7 @@
 /*
  * The MIT License (MIT)
  *
- * Copyright (c) 2015-2024 Advanced Micro Devices, Inc. All rights reserved.
+ * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved.
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -51,7 +51,7 @@ std::vector<char> src_compiler::compile(const std::vector<src_file>& srcs) const
         write_buffer(full_path, src.content.data(), src.content.size());
         if(src.path.extension().string() == ".cpp")
         {
-            params.emplace_back(src.path.filename().string());
+            params.emplace_back(src.path.string());
             if(out.empty())
                 out = src.path.stem().string() + out_ext;
         }

src/targets/gpu/CMakeLists.txt

@@ -78,8 +78,9 @@ else()
     set(MIGRAPHX_USE_HIPRTC ON CACHE BOOL "Use hipRTC APIs")
 endif()
 
-file(GLOB KERNEL_FILES CONFIGURE_DEPENDS
-    ${CMAKE_CURRENT_SOURCE_DIR}/kernels/include/migraphx/kernels/*.hpp)
+file(GLOB_RECURSE KERNEL_FILES CONFIGURE_DEPENDS LIST_DIRECTORIES false
+    ${CMAKE_CURRENT_SOURCE_DIR}/kernels/include/*.hpp
+)
 
 if(NOT MIGRAPHX_USE_COMPOSABLEKERNEL)
     list(REMOVE_ITEM KERNEL_FILES
@@ -117,6 +118,31 @@ if(HAS_HIP_LAMBDA_HOST_DEVICE)
     target_compile_options(compile_for_gpu INTERFACE -fhip-lambda-host-device)
 endif()
 
+function(check_hip_deduction_guide VAR)
+    set(CMAKE_REQUIRED_LIBRARIES hip::device)
+    check_cxx_source_compiles("
+template<class T>
+struct S
+{
+    T x;
+};
+
+template<class T>
+S(T) -> S<T>;
+
+__attribute__((device)) auto f()
+{
+    return S{1};
+}
+    " ${VAR})
+endfunction()
+check_hip_deduction_guide(HIP_HAS_WORKING_DEDUCTION_GUIDE)
+
+if(NOT HIP_HAS_WORKING_DEDUCTION_GUIDE)
+    message(STATUS "Enable deduction guide workaround")
+    target_compile_definitions(compile_for_gpu INTERFACE MIGRAPHX_WORKAROUND_BROKEN_DEDUCTION_GUIDE=1)
+endif()
+
 set_target_properties(migraphx_device PROPERTIES EXPORT_NAME device)
 rocm_set_soversion(migraphx_device ${MIGRAPHX_SO_VERSION})
 rocm_add_version_resource(migraphx_device "AMD MIGraphX" "MIGraphX Device Library - GPU Device Operations")
@@ -176,18 +202,22 @@ endif()
 
 add_library(migraphx_gpu_kernel_file_check EXCLUDE_FROM_ALL)
 
-set(CK_TIDY_SKIP_KERNEL_FILES "ck" "ck_gemm" "ck_gemm_softmax_gemm")
+set(CK_TIDY_SKIP_KERNEL_FILES ck ck_gemm ck_gemm_softmax_gemm)
 foreach(KERNEL_FILE ${KERNEL_FILES})
-    get_filename_component(KERNEL_BASE_FILE ${KERNEL_FILE} NAME_WE)
+    file(RELATIVE_PATH KERNEL_FILE_REL ${CMAKE_CURRENT_SOURCE_DIR}/kernels/include/ ${KERNEL_FILE})
+    get_filename_component(KERNEL_BASE_FILE ${KERNEL_FILE_REL} NAME_WE)
+    get_filename_component(KERNEL_DIR ${KERNEL_FILE_REL} DIRECTORY)
     # Temporary workaround for tidy issue that arises from the fact that CK no longer exposes headers to the host code
     if(${KERNEL_BASE_FILE} IN_LIST CK_TIDY_SKIP_KERNEL_FILES)
         continue()
     endif()
-    file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/kernels/include/migraphx/kernels/${KERNEL_BASE_FILE}.cpp "#include <migraphx/kernels/${KERNEL_BASE_FILE}.hpp>\n")
-    target_sources(migraphx_gpu_kernel_file_check PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/kernels/include/migraphx/kernels/${KERNEL_BASE_FILE}.cpp)
+    file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/kernels/include/${KERNEL_DIR}/${KERNEL_BASE_FILE}.cpp "#include <${KERNEL_DIR}/${KERNEL_BASE_FILE}.hpp>\n")
+    target_sources(migraphx_gpu_kernel_file_check PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/kernels/include/${KERNEL_DIR}/${KERNEL_BASE_FILE}.cpp)
 endforeach()
 
 target_link_libraries(migraphx_gpu_kernel_file_check compile_migraphx_gpu_kernels)
+# Copy the .clang-tidy files over
+configure_file(${CMAKE_CURRENT_SOURCE_DIR}/kernels/include/rocm/.clang-tidy ${CMAKE_CURRENT_BINARY_DIR}/kernels/include/rocm/.clang-tidy COPYONLY)
 
 rocm_clang_tidy_check(migraphx_gpu_kernel_file_check)
 

src/targets/gpu/compile_hip_code_object.cpp

@@ -213,7 +213,7 @@ compile_hip_raw(context& ctx, const std::string& content, hip_compile_options op
         kernels.end(),
         std::back_inserter(srcs),
         [](const std::pair<std::string_view, std::string_view>& elem) { return src_file{elem}; });
-    srcs.emplace_back("main.cpp", content);
+    srcs.emplace_back(options.src_file, content);
 
     if(options.global % options.local != 0 and hip_accept_non_uniform_wg())
         options.emplace_param("-fno-offload-uniform-block");

src/targets/gpu/include/migraphx/gpu/compile_hip_code_object.hpp

@@ -48,6 +48,7 @@ struct hip_compile_options
     std::vector<shape> virtual_inputs          = {};
     std::vector<src_file> additional_src_files = {};
     std::int64_t output_arg                    = -1;
+    std::string src_file                       = "main.cpp";
 
     /**
      * @brief Set the launch parameters but allow v to override the values

src/targets/gpu/kernels/include/migraphx/kernels/test.hpp

@@ -338,6 +338,14 @@ struct test_manager
     __device__ [[maybe_unused]] static void __VA_ARGS__( \
         [[maybe_unused]] migraphx::test::test_manager& migraphx_private_test_manager)
 
+// NOLINTNEXTLINE
+#define TEST_CASE_TEMPLATE(...)                          \
+    __device__ [[maybe_unused]] static void __VA_ARGS__( \
+        [[maybe_unused]] migraphx::test::test_manager& migraphx_private_test_manager)
+
+// NOLINTNEXTLINE
+#define TEST_CASE_REGISTER(...)
+
 } // namespace test
 } // namespace migraphx
 #endif // MIGRAPHX_GUARD_KERNELS_TEST_HPP

src/targets/gpu/kernels/include/rocm/.clang-tidy

@@ -0,0 +1,6 @@
+InheritParentConfig: True
+CheckOptions: 
+  - key:             readability-identifier-naming.MacroDefinitionPrefix
+    value:           ROCM_
+  - key:             readability-identifier-naming.ConstexprMethodIgnoredRegexp
+    value:           'quiet_NaN|signaling_NaN'

src/targets/gpu/kernels/include/rocm/algorithm.hpp

@@ -0,0 +1,55 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2025-2026 Advanced Micro Devices, Inc. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ *
+ */
+#ifndef ROCM_GUARD_ROCM_ALGORITHM_HPP
+#define ROCM_GUARD_ROCM_ALGORITHM_HPP
+
+#include <rocm/algorithm/iter_swap.hpp>
+#include <rocm/algorithm/fill.hpp>
+#include <rocm/algorithm/accumulate.hpp>
+#include <rocm/algorithm/copy.hpp>
+#include <rocm/algorithm/copy_if.hpp>
+#include <rocm/algorithm/transform.hpp>
+#include <rocm/algorithm/is_sorted_until.hpp>
+#include <rocm/algorithm/is_sorted.hpp>
+#include <rocm/algorithm/for_each.hpp>
+#include <rocm/algorithm/find_if.hpp>
+#include <rocm/algorithm/find.hpp>
+#include <rocm/algorithm/any_of.hpp>
+#include <rocm/algorithm/none_of.hpp>
+#include <rocm/algorithm/all_of.hpp>
+#include <rocm/algorithm/search.hpp>
+#include <rocm/algorithm/inner_product.hpp>
+#include <rocm/algorithm/equal.hpp>
+#include <rocm/algorithm/iota.hpp>
+#include <rocm/algorithm/min_element.hpp>
+#include <rocm/algorithm/max_element.hpp>
+#include <rocm/algorithm/rotate.hpp>
+#include <rocm/algorithm/upper_bound.hpp>
+#include <rocm/algorithm/lower_bound.hpp>
+#include <rocm/algorithm/sort.hpp>
+#include <rocm/algorithm/stable_sort.hpp>
+#include <rocm/algorithm/merge.hpp>
+
+#endif // ROCM_GUARD_ROCM_ALGORITHM_HPP

src/targets/gpu/kernels/include/rocm/algorithm/accumulate.hpp

@@ -0,0 +1,51 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2025-2026 Advanced Micro Devices, Inc. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ *
+ */
+#ifndef ROCM_GUARD_ROCM_ALGORITHM_ACCUMULATE_HPP
+#define ROCM_GUARD_ROCM_ALGORITHM_ACCUMULATE_HPP
+
+#include <rocm/config.hpp>
+
+namespace rocm {
+inline namespace ROCM_INLINE_NS {
+
+template <class InputIt, class T, class BinaryOperation>
+constexpr T accumulate(InputIt first, InputIt last, T init, BinaryOperation op)
+{
+    for(; first != last; ++first)
+    {
+        init = op(static_cast<T&&>(init), *first);
+    }
+    return init;
+}
+
+template <class InputIt, class T>
+constexpr T accumulate(InputIt first, InputIt last, T init)
+{
+    return accumulate(first, last, init, [](auto x, auto y) { return x + y; });
+}
+
+} // namespace ROCM_INLINE_NS
+} // namespace rocm
+#endif // ROCM_GUARD_ROCM_ALGORITHM_ACCUMULATE_HPP

src/targets/gpu/kernels/include/rocm/algorithm/all_of.hpp

@@ -0,0 +1,42 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2025-2026 Advanced Micro Devices, Inc. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ *
+ */
+#ifndef ROCM_GUARD_ROCM_ALGORITHM_ALL_OF_HPP
+#define ROCM_GUARD_ROCM_ALGORITHM_ALL_OF_HPP
+
+#include <rocm/config.hpp>
+#include <rocm/algorithm/none_of.hpp>
+
+namespace rocm {
+inline namespace ROCM_INLINE_NS {
+
+template <class InputIt, class UnaryPredicate>
+constexpr bool all_of(InputIt first, InputIt last, UnaryPredicate p)
+{
+    return none_of(first, last, [=](auto&& x) { return not p(x); });
+}
+
+} // namespace ROCM_INLINE_NS
+} // namespace rocm
+#endif // ROCM_GUARD_ROCM_ALGORITHM_ALL_OF_HPP

src/targets/gpu/kernels/include/rocm/algorithm/any_of.hpp

@@ -0,0 +1,42 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2025-2026 Advanced Micro Devices, Inc. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ *
+ */
+#ifndef ROCM_GUARD_ROCM_ALGORITHM_ANY_OF_HPP
+#define ROCM_GUARD_ROCM_ALGORITHM_ANY_OF_HPP
+
+#include <rocm/config.hpp>
+#include <rocm/algorithm/find_if.hpp>
+
+namespace rocm {
+inline namespace ROCM_INLINE_NS {
+
+template <class InputIt, class UnaryPredicate>
+constexpr bool any_of(InputIt first, InputIt last, UnaryPredicate p)
+{
+    return find_if(first, last, p) != last;
+}
+
+} // namespace ROCM_INLINE_NS
+} // namespace rocm
+#endif // ROCM_GUARD_ROCM_ALGORITHM_ANY_OF_HPP

src/targets/gpu/kernels/include/rocm/algorithm/copy.hpp

@@ -0,0 +1,45 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2025-2026 Advanced Micro Devices, Inc. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ *
+ */
+#ifndef ROCM_GUARD_ROCM_ALGORITHM_COPY_HPP
+#define ROCM_GUARD_ROCM_ALGORITHM_COPY_HPP
+
+#include <rocm/config.hpp>
+
+namespace rocm {
+inline namespace ROCM_INLINE_NS {
+
+template <class InputIt, class OutputIt>
+constexpr OutputIt copy(InputIt first, InputIt last, OutputIt d_first)
+{
+    while(first != last)
+    {
+        *d_first++ = *first++;
+    }
+    return d_first;
+}
+
+} // namespace ROCM_INLINE_NS
+} // namespace rocm
+#endif // ROCM_GUARD_ROCM_ALGORITHM_COPY_HPP