Skip to content

855 improve comparison view#856

Draft
jacobvjk wants to merge 4 commits into
mainfrom
855-improve-comparison-view
Draft

855 improve comparison view#856
jacobvjk wants to merge 4 commits into
mainfrom
855-improve-comparison-view

Conversation

@jacobvjk

Copy link
Copy Markdown
Collaborator

closes #855

This PR:

  • more clearly differentiates between expanded/collapsed states of the comparison ribbon

    • Lifted ribbon expanded/collapsed state into ComparisonContext so ComparisonRibbon and PathwayCard share it
    • The add-to-comparison button on PathwayCard is now hidden when the ribbon is collapsed
  • Benchmark Metric Plots section moved above Key Features on the comparison page

  • Shared geography filter

    • Geography selector is now shared across all pathway columns in the comparison view (instead of per-panel)
    • Available geographies in the geography selector are derived as the union across all compared pathways
    • Plots with no data for the selected geography show a contextual message instead of a generic "No data available"
  • Shared Y-axis bounds

    • MultiLineChart (capacity, generation): shared Y min and max across all pathways for the selected geography
    • VerticalBarChart (absolute emissions, emissions intensity): shared Y max; axis always starts at 0
  • Cross-chart hover highlighting in the comparison view

    • Hovering a series in one pathway's chart dims all other series in all other pathway charts (only affects MultiLineChart)
  • Plot title wrapping

    • Chart titles moved from SVG elements to HTML

      tags so they wrap instead of getting clipped on narrow panels

  • Tests

    • Updated ComparisonRibbon.test.tsx to reflect context-driven expand state
    • Added ComparisonPlots.test.tsx covering geography union logic, selector visibility, and the per-panel no-data message

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Expected version change and release notes:

1.15.0-dev.7 (v1.15.0-dev.6...855-improve-comparison-view ) (2026-07-13T16:29 UTC)

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-856.westus2.2.azurestaticapps.net

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-856.westus2.2.azurestaticapps.net

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-856.westus2.2.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: tidy up comparison view

1 participant