WP-306 draft schemas for climate trace outputs#26
Open
HughRunyan wants to merge 2 commits into
Open
Conversation
andre-scheinwald
approved these changes
Jun 26, 2026
Collaborator
There was a problem hiding this comment.
Seems pretty straight forward. Replacing hardcoded values everywhere with a single constant from another repo.
I have 1 suggestion. I noticed you have MODEL_END_YEAR + 1 everywhere in city_params because you're using range. Makes sense. I think it would be beneficial here to have a global variable outside the funcs. Something like:
MODEL_END_YEAR_PLUS_1 = MODEL_END_YEAR + 1
And then replace every instance of MODEL_END_YEAR + 1 with the global var.
This way if you ever have to tweak this you only have to change it on one line. Vs. every line it shows up in.
Up to you if this makes sense or not.
Saw there's a merge conflict, good luck!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with #55 in RMI Climate TRACE repo.
The changes are mostly hardcoded values for constants, cleaning up the handling of modeling time window.