Skip to content

WP-306 draft schemas for climate trace outputs#26

Open
HughRunyan wants to merge 2 commits into
mainfrom
schemas
Open

WP-306 draft schemas for climate trace outputs#26
HughRunyan wants to merge 2 commits into
mainfrom
schemas

Conversation

@HughRunyan

@HughRunyan HughRunyan commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Pairs with #55 in RMI Climate TRACE repo.

The changes are mostly hardcoded values for constants, cleaning up the handling of modeling time window.

@HughRunyan HughRunyan changed the title Pairs with #55 in RMI Climate TRACE repo WP-306 draft schemas for climate trace outputs Jun 25, 2026

@andre-scheinwald andre-scheinwald left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight forward. Replacing hardcoded values everywhere with a single constant from another repo.

I have 1 suggestion. I noticed you have MODEL_END_YEAR + 1 everywhere in city_params because you're using range. Makes sense. I think it would be beneficial here to have a global variable outside the funcs. Something like:

MODEL_END_YEAR_PLUS_1 = MODEL_END_YEAR + 1

And then replace every instance of MODEL_END_YEAR + 1 with the global var.
This way if you ever have to tweak this you only have to change it on one line. Vs. every line it shows up in.
Up to you if this makes sense or not.

Saw there's a merge conflict, good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants