Remove outdated waivers#626
Merged
matusmarhefka merged 8 commits intoMay 21, 2026
Merged
Conversation
The issue with rule chrony_set_nts doesn't occur anymore because this rule has been removed from RHEL 10 profiles by ComplianceAsCode/content#14613
The rule configure_libreswan_crypto_policy has been aligned with DISA by ComplianceAsCode/content#14477 and is no longer reported by the DISA alignment tests.
Remove waivers for rule accounts_umask_etc_bashrc and accounts_umask_etc_profile. These rules started passing because hummingbird has changed the default umask value in their images, see https://gitlab.com/redhat/hummingbird/rpms/-/merge_requests/2016
The rules `coredump_disable_backtraces` and `coredump_disable_storage` are misaligned with DISA's content, see ComplianceAsCode/content#13676 However, the rules are never evaluated because they are marked as conflicting with rule `sysctl_kernel_core_pattern`. The `conflicts` statement has been added to the rules in ComplianceAsCode/content@92a35be Since these rules aren't evaluated, they aren't examined by the `disa-alignment` test, therefore they don't show up in the test results and the waiver is superfluous.
The linked issue ComplianceAsCode/content#14558 has been fixed upstream. The test didn't fail in the latest stabilization run.
The linked issue ComplianceAsCode/content#14560 has been fixed upstream and the issue doesn't manifest in the stabilization test run.
The referenced issue ComplianceAsCode/content#14563 has been fixed upstream and the fail didn't happen in the latest stabilization test run.
The linked issues ComplianceAsCode/content#14669 and ComplianceAsCode/content#14582 have been fixed and the tests don't error in the stabilization run on RHEL 9.
matusmarhefka
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the 0.1.81 release stabilization multiple outdated waivers were found. The waived tests no longer manifest.
For more details, please read commit messages of every commit.