[ENH] Spectra transformers#44
Open
ngergihun wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new spectrum transformation classes and extends the test coverage for these transformations in the
pySNOMpackage. The main additions are theCut,Scale, andConstantNormalizetransformations, as well as enhancements to theRotatePhasetransformation. Comprehensive unit tests have been added to ensure correctness and reliability of these new and modified features.New spectrum transformation classes:
Cutclass to extract a spectral region between two wavenumbers from a spectrum (pySNOM/spectra.py).Scaleclass to scale amplitude or phase data by a specified factor (pySNOM/spectra.py).ConstantNormalizeclass for normalization by a constant value or by a value from the spectrum at a specific wavenumber, supporting both amplitude and phase data (pySNOM/spectra.py).Enhancements to existing transformations:
RotatePhaseclass to support an optional constant phase shift in addition to the wavenumber-scaled phase shift (pySNOM/spectra.py).Test coverage improvements:
Cut,Scale, andConstantNormalizetransformations, as well as for the enhancedRotatePhaseand other normalization methods (pySNOM/tests/test_spectra.py).