Fix double spend bug#514
Closed
dewabisma wants to merge 3 commits into
Closed
Conversation
Collaborator
|
Same as #515 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
High Risk
Changes core transaction submission and nonce handling for all sends; incorrect retry or hash logic could still drop or mis-track in-flight transfers.
Overview
Fixes a double-spend risk where app-level submission retries re-ran the builder and signed new extrinsics (incrementing nonce) while an earlier attempt might already be in the pool.
Mobile:
TransactionSubmissionServicedropsmaxRetriesand the recursive retry loop in_submitAndTrackBackground; each user action triggers a singlesubmissionBuilder()call, with RPC resilience documented as living inSubstrateService.submitExtrinsic. Review send adds an earlyif (_submitting) returnon confirm to block duplicate taps.SDK:
submitExtrinsicnow builds and signs the payload once, then retries broadcasting the same signed bytes. Newextrinsic_submission_utilstreats Substrate 1013 / already imported as success by returninglocalExtrinsicHash(extrinsic)so tracking can continue without re-signing. Unit tests cover the helpers.Reviewed by Cursor Bugbot for commit f4eba5f. Configure here.