test: add renamed equity ticker scaffold test - #35
Merged
Conversation
- new brokerages start with a test that a symbol carrying the historical permtick still maps to the ticker that is current today, for the equity and for the option root - format-agnostic assertions; the implementer only plugs in the plugin symbol mapper
Martin-Molinero
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
ReturnsCurrentTickerAfterEquityTickerChangeto the template symbol mapper tests. Equity tickers change over the life of a SID (e.g.GOOCV -> GOOG), and a Symbol can still carry the old ticker inValue— for example an order reloaded from disk, whoseValuedefaults to the SID permtick. Several brokerage plugins sent that old ticker to the broker because the mapper readSymbol.Value/Symbol.Underlying.Valueinstead of resolving withSecurityIdentifier.Ticker(symbol, DateTime.UtcNow).The scaffold test bakes this check into every new brokerage: a Symbol carrying the historical permtick must map to the current ticker, for the equity and for the equity option root. The assertions use
Contains, so they hold for any brokerage symbol format (plain ticker, OSI option string, ticker with market suffix). The implementer only replaces theISymbolMapper symbolMapper = null;TODO line with the plugin's mapper. The fixture keeps its class-levelIgnoreuntil the plugin implements it.Related PR(s)
The bug and fix pattern this test guards against:
Related Issue
N/A
Motivation and Context
The same renamed-equity ticker bug appeared independently in six brokerage plugins. New plugins scaffolded from this template should start with the test that catches it.
Requires Documentation Change
No
How Has This Been Tested?
The test project compiles and the fixture is skipped as before (class-level
Ignoreuntil the plugin is implemented). The same test cases (GOOCV -> GOOG,GOOG -> GOOGL) run green in the CharlesSchwab, WeBull, Eze, TerminalLink, and Fix.Bloomberg plugins.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>