fix: editor bold resets text color & Ctrl+B toggles sidebar#80
Open
giorgigordiashvili wants to merge 1 commit into
Open
fix: editor bold resets text color & Ctrl+B toggles sidebar#80giorgigordiashvili wants to merge 1 commit into
giorgigordiashvili wants to merge 1 commit into
Conversation
…r conflict - Add prose-strong:text-inherit to the editor so bold text inherits the color from its parent span instead of resetting to the prose default color - Skip the sidebar Ctrl+B shortcut when the event target is inside a contenteditable element, letting the editor handle it Closes Qualiora#76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proseclass applies its owncolorto<strong>elements, overriding the inherited inline color from the parent<span style="color: ...">. Fixed by addingprose-strong:text-inheritso bold text inherits the color set by the color picker.keydownhandler catchesCtrl+Beven when focus is inside the rich text editor. Fixed by skipping the handler whenevent.targetis acontentEditableelement.Closes #76
Test plan
/extended-ui/editor