Skip to content

feat(QOV-1999): GKE allow private nodes for user provided VPC#2758

Open
benjaminch wants to merge 1 commit into
stagingfrom
feat/QOV-1999/gke-allow-private-nodes-for-user-provided-vpc
Open

feat(QOV-1999): GKE allow private nodes for user provided VPC#2758
benjaminch wants to merge 1 commit into
stagingfrom
feat/QOV-1999/gke-allow-private-nodes-for-user-provided-vpc

Conversation

@benjaminch

Copy link
Copy Markdown
Collaborator

Ticket: QOV-1999

Summary

Issue: QOV-1999

This PR allows users to activate private nodes on GKE for custom VPC.

Screenshots / Recordings

CleanShot 2026-06-15 at 15 21 41 CleanShot 2026-06-15 at 15 20 40

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@benjaminch benjaminch added the enhancement New feature or request label Jun 15, 2026
@benjaminch benjaminch force-pushed the feat/QOV-1999/gke-allow-private-nodes-for-user-provided-vpc branch from 837936b to c209795 Compare June 15, 2026 14:04
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.48%. Comparing base (eda6615) to head (cb97e44).
⚠️ Report is 2 commits behind head on staging.

Files with missing lines Patch % Lines
...ster-creation-flow/step-features/step-features.tsx 0.00% 1 Missing ⚠️
...on-flow/step-summary/step-summary-presentation.tsx 0.00% 0 Missing and 1 partial ⚠️
...luster-creation-flow/step-summary/step-summary.tsx 0.00% 0 Missing and 1 partial ⚠️
...ster-network-settings/cluster-network-settings.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2758      +/-   ##
===========================================
+ Coverage    46.37%   46.48%   +0.10%     
===========================================
  Files         1211     1211              
  Lines        25735    25752      +17     
  Branches      7584     7588       +4     
===========================================
+ Hits         11935    11970      +35     
+ Misses       11713    11691      -22     
- Partials      2087     2091       +4     
Flag Coverage Δ
unittests 46.48% <42.85%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements support for configuring GKE “private nodes” when creating a cluster on GCP with a user-provided (existing) VPC, and ensures the selected value is propagated through the creation payload and shown in summaries/settings.

Changes:

  • Bumps qovery-typescript-axios to include the latest API contract needed for the new feature field(s).
  • Adds private_nodes to the GCP existing VPC feature data model and cluster creation payload building.
  • Updates UI (feature step, summary, and network settings read-only display) and adds/updates unit tests accordingly.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
yarn.lock Updates lockfile for the qovery-typescript-axios version bump.
package.json Bumps qovery-typescript-axios dependency to 1.1.911.
libs/shared/interfaces/src/lib/domain/cluster-creation-flow.interface.ts Extends cluster creation flow data to include private_nodes under gcp_existing_vpc.
libs/domains/clusters/feature/src/lib/cluster-network-settings/cluster-network-settings.tsx Displays “Private nodes” for GCP existing VPC network settings (read-only).
libs/domains/clusters/feature/src/lib/cluster-network-settings/cluster-network-settings.spec.tsx Adds coverage for rendering the GCP existing VPC “Private nodes” display.
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary.tsx Includes private_nodes in the EXISTING_VPC payload for GCP.
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary.spec.tsx Adds test ensuring private_nodes is sent in the create payload.
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary-presentation.tsx Displays private_nodes in the summary UI for GCP existing VPC.
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary-presentation.spec.tsx Adds test for rendering the “Private nodes” summary row.
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-features/step-features.tsx Persists private_nodes into featuresData for the GCP existing VPC mode.
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-features/gcp-vpc-feature/gcp-vpc-feature.tsx Adds a toggle to select gcp_existing_vpc.private_nodes.
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-features/gcp-vpc-feature/gcp-vpc-feature.spec.tsx Updates tests to assert presence of the new “Private nodes” toggle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@benjaminch benjaminch force-pushed the feat/QOV-1999/gke-allow-private-nodes-for-user-provided-vpc branch from c209795 to 9a15d64 Compare June 16, 2026 12:56
@benjaminch benjaminch force-pushed the feat/QOV-1999/gke-allow-private-nodes-for-user-provided-vpc branch from 9a15d64 to cb97e44 Compare June 16, 2026 15:25
@benjaminch benjaminch requested a review from rmnbrd June 17, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants