feat(QOV-1999): GKE allow private nodes for user provided VPC#2758
feat(QOV-1999): GKE allow private nodes for user provided VPC#2758benjaminch wants to merge 1 commit into
Conversation
837936b to
c209795
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2758 +/- ##
===========================================
+ Coverage 46.37% 46.48% +0.10%
===========================================
Files 1211 1211
Lines 25735 25752 +17
Branches 7584 7588 +4
===========================================
+ Hits 11935 11970 +35
+ Misses 11713 11691 -22
- Partials 2087 2091 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR implements support for configuring GKE “private nodes” when creating a cluster on GCP with a user-provided (existing) VPC, and ensures the selected value is propagated through the creation payload and shown in summaries/settings.
Changes:
- Bumps
qovery-typescript-axiosto include the latest API contract needed for the new feature field(s). - Adds
private_nodesto the GCP existing VPC feature data model and cluster creation payload building. - Updates UI (feature step, summary, and network settings read-only display) and adds/updates unit tests accordingly.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates lockfile for the qovery-typescript-axios version bump. |
| package.json | Bumps qovery-typescript-axios dependency to 1.1.911. |
| libs/shared/interfaces/src/lib/domain/cluster-creation-flow.interface.ts | Extends cluster creation flow data to include private_nodes under gcp_existing_vpc. |
| libs/domains/clusters/feature/src/lib/cluster-network-settings/cluster-network-settings.tsx | Displays “Private nodes” for GCP existing VPC network settings (read-only). |
| libs/domains/clusters/feature/src/lib/cluster-network-settings/cluster-network-settings.spec.tsx | Adds coverage for rendering the GCP existing VPC “Private nodes” display. |
| libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary.tsx | Includes private_nodes in the EXISTING_VPC payload for GCP. |
| libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary.spec.tsx | Adds test ensuring private_nodes is sent in the create payload. |
| libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary-presentation.tsx | Displays private_nodes in the summary UI for GCP existing VPC. |
| libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary-presentation.spec.tsx | Adds test for rendering the “Private nodes” summary row. |
| libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-features/step-features.tsx | Persists private_nodes into featuresData for the GCP existing VPC mode. |
| libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-features/gcp-vpc-feature/gcp-vpc-feature.tsx | Adds a toggle to select gcp_existing_vpc.private_nodes. |
| libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-features/gcp-vpc-feature/gcp-vpc-feature.spec.tsx | Updates tests to assert presence of the new “Private nodes” toggle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c209795 to
9a15d64
Compare
Ticket: QOV-1999
9a15d64 to
cb97e44
Compare
Ticket: QOV-1999
Summary
Issue: QOV-1999
This PR allows users to activate private nodes on GKE for custom VPC.
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release