Skip to content

Accept multiple solutions #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yutounun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Accept multiple solutions #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 12 additions & 24 deletions scripts/leetcode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,31 +219,19 @@ function uploadGit(
) {
sha = stats.sha[filePath];
}
const uniqueFileName = `${fileName}-${Math.random()}`;
Copy link
Copy Markdown

@willyfh willyfh Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't guarantee the filename will be unique. There is a possibility that the filename could get duplicated due to the randomness.


if (action === 'upload') {
/* Upload to git. */
upload(
token,
hook,
code,
problemName,
fileName,
sha,
msg,
cb,
);
} else if (action === 'update') {
Copy link
Copy Markdown

@willyfh willyfh Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, why action 'update' and action 'upload conditions are removed here?

/* Update on git */
update(
token,
hook,
code,
problemName,
msg,
prepend,
cb,
);
}
/* Upload to git. */
upload(
token,
hook,
code,
problemName,
uniqueFileName,
sha,
msg,
cb,
);
});
}
});
Expand Down