Protect DescentEngine object exposure#6045
Merged
Merged
Conversation
…nd QMCFixedSampleLinearOptimize::engine_start
Contributor
Author
|
Test this please |
prckent
reviewed
Jul 15, 2026
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
Q. Is _le_list guaranteed to be initialized or does _le_list(1) also need to be added in the initializer list?
Contributor
Author
I didn’t see it being accessed. No needed to be initialized to size 1 proactively. ASAN should catch this if it causes an issue. |
prckent
approved these changes
Jul 15, 2026
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
Thank you.
Confirmed that the H4 short tests ran without crashing on macos macports gcc-15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #5913 #6044 and #6040
Re-applied Paul's fix in #6044 for #5913.
Protect DescentEngine with an optional reference type.
Consolidate engine_start and engine_checkConfigurations arguments.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
bora. with gcc 15.3
Checklist