Nexus: Add PseudoSet class to improve pseudopotential handling for users.#6043
Open
brockdyer03 wants to merge 18 commits into
Open
Nexus: Add PseudoSet class to improve pseudopotential handling for users.#6043brockdyer03 wants to merge 18 commits into
PseudoSet class to improve pseudopotential handling for users.#6043brockdyer03 wants to merge 18 commits into
Conversation
…g for POTCARs, add `__repr__` for `PseudoSet`
…on's limitations...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a class called
PseudoSetto Nexus that will eventually replace the existingppsetclass.PseudoSetoffers a more flexible and intuitive API for users that offers several advantages over the currentppset. Some notable advantages are:pseudo_dirinsettings).PseudoSet.from_dir().PseudoSet.from_mixed_dir().PseudoSet.get_Zeffs().ppsetwithPseudoSet._register_legacy_ppset().Example usage
I've included some examples here so you don't need to pore through the code to see how the functions work.
The examples here assume the following contents of
pseudo_dirPseudoSet.from_dir()PseudoSet.from_mixed_dir()What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Laptop, Fedora Linux 43 (KDE Plasma Desktop Edition)
AMD Ryzen 7 PRO 7840U (8 cores, 16 logical processors)
Checklist