Change ECR to use TF official module

[ronkq]

Change ECR provisioning to use TF official module.
When moving to use official modules we can't customize them, so some resources could be removed.
In terms of terraform state, terragrunt will consider it as a new module, where we will import the cloud resources to, and make sure the plan is without any changes, to keep our code aligned to the existing cloud resources. At this point we'll have 2 different terragrunt modules "owning" the same cloud resources, after which we will remove the old module references from the state.

[PaulLaux]

1. In testnet-single-node-deploy/infra/terragrunt-aws-environments/dev/eu-central-1/zsa/ecs-swaps/terragrunt.hcl we have image = "${dependency.ecr.outputs.ecr-url}:latest" but we no longer have outputs.ecr-url. You deleted it in this PR. Same for infra/terragrunt-aws-environments/dev/eu-central-1/zsa/ecs/terragrunt.hcl and infra/terragrunt-aws-environments/dev/eu-central-1/zsa/lambda/lambda/terragrunt.hcl

2. changing to

terraform {
  source = "git::https://github.com/terraform-aws-modules/terraform-aws-ecr.git?ref=v2.4.0"
}

together with force_delete = true will remove the old module (the id has changes) together with all previous images. Is that what we want?

3. This PR should be applied after #150 (dependant on cicd-user changes). A better way is to point this PR on top 150 to force order.

[ronkq]

1. In testnet-single-node-deploy/infra/terragrunt-aws-environments/dev/eu-central-1/zsa/ecs-swaps/terragrunt.hcl we have image = "${dependency.ecr.outputs.ecr-url}:latest" but we no longer have outputs.ecr-url. You deleted it in this PR. Same for infra/terragrunt-aws-environments/dev/eu-central-1/zsa/ecs/terragrunt.hcl and infra/terragrunt-aws-environments/dev/eu-central-1/zsa/lambda/lambda/terragrunt.hcl
2. changing to

terraform {
  source = "git::https://github.com/terraform-aws-modules/terraform-aws-ecr.git?ref=v2.4.0"
}

together with force_delete = true will remove the old module (the id has changes) together with all previous images. Is that what we want?

3. This PR should be applied after Change CICD GH IAM user to use TF official module #150 (dependant on cicd-user changes). A better way is to point this PR on top 150 to force order.

1. There will be also adjustments to ECS
2. We will not destroy or apply the modules before doing state import, and seeing that there are no changes.
3. Changed