a11y semantics + macOS/standalone build fixes#12
Merged
Conversation
Salvages the safe, English parts of #1 (which also bundled a Spanish UI fork, a personal sync script, and an unverified supervisor/sub-agent feature — those are intentionally left out). a11y: - lib/a11y: reusable prop factories (modalProps, chatLogProps, statusRegionProps, composerProps, ariaExpanded, ariaCurrent) - chat message list as a role="log" aria-live region; streaming cursor as a status region; composer aria-label + describedby + sr-only hint - role="dialog"/aria-modal on settings, channel, invite, onboarding modals - <nav aria-label> + aria-current on the server rail; aria-expanded on channel group toggles; search input aria-label - .sr-only utility; setAccessibilitySupportEnabled(true) after app ready build: - next.config: outputFileTracingRoot pins the trace root so the standalone server.js lands at the bundle root (was misplaced when a home-dir lockfile made Next infer ~/ as the monorepo root) - electron/after-pack: resolve the macOS .app Resources dir so the standalone server is copied inside the bundle Co-authored-by: aitorf2 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages the safe, English parts of #1. Verified:
tsc --noEmit,eslint,npm run test:migration,npm run test:smoke, andnpm run build(standaloneserver.jsconfirmed at bundle root).a11y
lib/a11y: reusable prop factories (modalProps,chatLogProps,statusRegionProps,composerProps,ariaExpanded,ariaCurrent)role="log"aria-liveregion; streaming cursor as a status region; composeraria-label+aria-describedby+sr-onlyhintrole="dialog"/aria-modalon the settings, channel, invite, and onboarding modals<nav aria-label>+aria-currenton the server rail;aria-expandedon channel group toggles; search inputaria-label.sr-onlyutility;setAccessibilitySupportEnabled(true)after app readybuild
next.config:outputFileTracingRootpins the trace root so standaloneserver.jslands at the bundle root (was misplaced when a home-dir lockfile made Next infer~/as the monorepo root)electron/after-pack: resolve the macOS.appResources dir so the standalone server is copied inside the bundleDeliberately excluded from #1: the Spanish UI fork (
lang="es"+ es-only string table, no locale switch), the personalsync-upstream.sh, and the supervisor/sub-agent feature (had a Windows shell-injection path and used unverifiedclaude --agent/--bareflags — worth resubmitting separately, tested and secured). The Hermes fix from #1 already landed via #2.Co-authored-by: aitorf2 [email protected]