You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @alexjamesgodfrey — awesome work on this, thanks for sharing it!
Quick question: in _make_transfer_protocol_xml each <wp> only carries n / dn / v
(source, dest, volume). I'm wondering if <wp> might also take a per-transfer offset /
XY coordinate that just didn't show up in your capture.
The Echo can dispense to arbitrary positions on a destination (MALDI plates, slides,
membranes — feature-based stuff), so if your Wireshark session was a normal plate-to-plate
reformat, an optional offset attribute would never have hit the wire even if the firmware
supports it. Might just be hiding rather than missing.
Could be totally wrong (haven't tested on hardware), maybe offsets only live at the
plate-type level (A1OffsetX/Y etc.). But did you ever see anything on <wp> beyond n/dn/v,
or have a capture from a non-plate destination?
Happy to help test on hardware if useful — thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft support for Labcyte (acq Beckman) echo support under PyLabRobot's v1b1 architecture.
I only have the echo 650 so this will be tailored to that specific machine for now.
This includes:
DoWellTransferexecution for existing Echo protocol XML viado_well_transfer()andEchoTransferPrintOptionsTodo
Validation (WIP)
uv run --with pytest --with pytest-timeout python -m pytest pylabrobot/labcyte/echo_tests.py pylabrobot/capabilities/plate_access/plate_access_tests.pyuv run --with ruff ruff check pylabrobot/labcyte pylabrobot/capabilities/plate_access