cleanup: factor getSiblingsNodes helper, rename for-Until variant#587
Open
jvoisin wants to merge 1 commit into
Open
cleanup: factor getSiblingsNodes helper, rename for-Until variant#587jvoisin wants to merge 1 commit into
jvoisin wants to merge 1 commit into
Conversation
Most callers of getSiblingNodes pass nil, nil for the trailing untilm/untilNodes args, the until criteria only apply to the Next/Prev *Until family. This commit splits the function in two: 1. Rename getSiblingNodes -> getSiblingNodesUntil; the name now matches the parameter shape. 2. getSiblingNodes(nodes, st) is now a helper that calls getSiblingNodesUntil(nodes, st, nil, nil). It makes the code a bit more clear, as more than once I wondered what where the last two parameters from getSiblingNodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most callers of getSiblingNodes pass nil, nil for the trailing untilm/untilNodes args, the until criteria only apply to the Next/Prev *Until family. This commit splits the function in two:
It makes the code a bit more clear, as more than once I wondered what where the last two parameters from getSiblingNodes