perf: skip mapNodes dedup map in FindNodes#577
Open
jvoisin wants to merge 1 commit into
Open
Conversation
Each source node passed to FindNodes maps to at most itself (when it is a descendant of the current selection), so there is nothing to deduplicate across distinct sources. Replace the mapNodes call and its per-node callback/slice allocations with a direct append loop. Duplicate input nodes are still discarded with a cheap isInSlice check (run before the more expensive sliceContains tree walk) so the resulting Selection stays a proper set, matching the previous behaviour. benchstat: sec/op -43.68% B/op -82.00% allocs 85 -> 9 Add TestFindNodesDuplicateInput to cover the duplicate-input case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each source node passed to FindNodes maps to at most itself (when it is a descendant of the current selection), so there is nothing to deduplicate across distinct sources. Replace the mapNodes call and its per-node callback/slice allocations with a direct append loop.
Duplicate input nodes are still discarded with a cheap isInSlice check (run before the more expensive sliceContains tree walk) so the resulting Selection stays a proper set, matching the previous behaviour.
benchstat:
sec/op -43.68%
B/op -82.00%
allocs 85 -> 9
Add TestFindNodesDuplicateInput to cover the duplicate-input case.