Skip to content

fix: stopped uploading frontend to gh release #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raven-wing merged 1 commit into from
Jun 29, 2026
Merged

fix: stopped uploading frontend to gh release #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,11 @@
- name: Build package
run: make build

# TODO: also publish the frontend bundle to a CDN as part of the release,
# so deployments can opt out of serving it from Flask via
# GOODMAP_FRONTEND_LIB_URL. Until then it ships bundled in the wheel and is
# only attached to the GitHub Release below.
- name: Attach frontend bundle to GitHub Release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: gh release upload "${{ needs.release-please.outputs.tag_name }}" goodmap/static/frontend/index.min.js --clobber

# TODO: publish the frontend bundle to a CDN as part of the release, so

Check warning on line 86 in .github/workflows/release.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 


See more on https://sonarcloud.io/project/issues?id=Problematy_goodmap&issues=AZ8TZio1iwrsq3SR8jsi&open=AZ8TZio1iwrsq3SR8jsi&pullRequest=369
# deployments can opt out of serving it from Flask via
# GOODMAP_FRONTEND_LIB_URL. The bundle ships inside the wheel (pyproject
# include); it is intentionally NOT attached to the GitHub Release because
# published releases are immutable and reject post-publish asset uploads.
- name: Publish package distributions to PyPI
uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b
with:
Expand Down
Loading