Fix AJAX newsletter form selector for Hummingbird theme#126
Open
Codencode wants to merge 1 commit into
Open
Conversation
kpodemski
approved these changes
May 26, 2026
Codencode
added
the
Waiting for QA by Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current JavaScript submit handler targets the newsletter form using the legacy Classic theme selector:
$('.block_newsletter form')This works correctly with the Classic theme, where the newsletter form is rendered inside
.block_newsletter.However, in the Hummingbird theme, the newsletter subscription form uses the
.ps-emailsubscriptionclass. Because this selector is not currently included, the AJAX submit handler is not attached to the form and the newsletter registration via AJAX is not triggered as expected.This PR extends the selector to also include the Hummingbird markup:
$('.block_newsletter form, .ps-emailsubscription form')2. Go to the storefront.
3. Use the newsletter subscription form in the footer.
4. Enter a valid email address and submit the form.
5. Verify that the page is not reloaded.
6. Verify that the subscription is handled through an AJAX request.
7. Confirm that the expected success or error message is displayed after the AJAX response.
Without PR
without-pr.webm
With PR
with-pr.webm