Skip to content

[WIP] Experiment on getting GitHub Packages packages correct casing #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
o-l-a-v wants to merge 5 commits into
base: master
Choose a base branch
from
+32 −3
Draft

[WIP] Experiment on getting GitHub Packages packages correct casing #1855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b35023
Use explicit type
o-l-a-v Aug 11, 2025
4688565
Simplify type name
o-l-a-v Aug 11, 2025
d7a53fc
Experimenting on getting case of GitHub Packages packages
o-l-a-v Aug 11, 2025
f2b645b
Don't want the extension yo
o-l-a-v Aug 11, 2025
4c99710
Merge branch 'master' into fix-1446-github-packages-lowercase
o-l-a-v May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions src/code/InstallHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,8 +1028,8 @@ private bool TryInstallToTempPath(

File.Delete(pathToFile);

var moduleManifest = Path.Combine(tempDirNameVersion, pkgName + PSDataFileExt);
var scriptPath = Path.Combine(tempDirNameVersion, pkgName + PSScriptFileExt);
string moduleManifest = Path.Combine(tempDirNameVersion, pkgName + PSDataFileExt);
string scriptPath = Path.Combine(tempDirNameVersion, pkgName + PSScriptFileExt);

bool isModule = File.Exists(moduleManifest);
bool isScript = File.Exists(scriptPath);
Expand Down Expand Up @@ -1066,6 +1066,15 @@ private bool TryInstallToTempPath(
return false;
}

// Get module actual name with correct casing
string moduleManifestActualFileName = Path.GetFileNameWithoutExtension(
Directory.GetFiles(
tempDirNameVersion,
$"{pkgName}.psd1"
)[0]
);
_cmdletPassedIn.WriteVerbose($"pkgName: \"{pkgName}\", actual name of manifest: \"${moduleManifestActualFileName}");

if (!Utils.TryReadManifestFile(
manifestFilePath: moduleManifest,
manifestInfo: out Hashtable parsedMetadataHashtable,
Expand Down Expand Up @@ -1118,12 +1127,32 @@ private bool TryInstallToTempPath(
}
return false;
}

// Get script actual name with correct casing
string scriptActualFileName = Path.GetFileNameWithoutExtension(
Directory.GetFiles(
tempDirNameVersion,
$"{pkgName}.ps1"
)[0]
);
_cmdletPassedIn.WriteVerbose($"pkgName: \"{pkgName}\", actual name of script: \"{scriptActualFileName}\"");
}
else
{
// This package is not a PowerShell package (eg a resource from the NuGet Gallery).
installPath = _pathsToInstallPkg.Find(path => path.EndsWith("Modules", StringComparison.InvariantCultureIgnoreCase));

_cmdletPassedIn.WriteVerbose($"This resource is not a PowerShell package and will be installed to the modules path: {installPath}.");
isModule = true;

// Get actual name from .nuspec file
string resourceNuspecFileName = Path.GetFileNameWithoutExtension(
Directory.GetFiles(
tempDirNameVersion,
$"{pkgName}.nuspec"
)[0]
);
_cmdletPassedIn.WriteVerbose($"pkgName: \"{pkgName}\", actual name of nuspec file: \"{resourceNuspecFileName}\"");
// TODO: pass in ConcurrentQueue to write out verbose message.
// _cmdletPassedIn.WriteVerbose($"This resource is not a PowerShell package and will be installed to the modules path: {installPath}.");
isModule = true;
Expand Down
2 changes: 1 addition & 1 deletion src/code/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ private static bool TryReadPSDataFile(
{
throw new PSArgumentNullException(nameof(filePath));
}
string contents = System.IO.File.ReadAllText(filePath);
string contents = File.ReadAllText(filePath);

// Validate that the file content conforms to restricted language rules before execution.
// This parses the content into an AST and statically validates it only contains data-file-safe constructs (hashtables, arrays, literals, etc).
Expand Down