Filter expr wip#2643
Draft
shivamka1 wants to merge 107 commits into
Draft
Conversation
…oving string dispatch
…ps with direct methods on Id accepting T: Into<GID>
…ing NodeNameFilterBuilder/NodeTypeFilterBuilder
…ing NodeNameFilterBuilder/NodeTypeFilterBuilder
…rs (windowed + layered)
…_expr # Conflicts: # raphtory/src/db/graph/views/filter/model/node_expr.rs
…e full filter-building pipeline on each type
…ilder → TemporalProp/Quantified/Aggregated
…ilterOps from prelude
… to restore dot-syntax property filter ops
…e .property().temporal() instead
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: a5baeb6 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
7823743 ns/iter (± 42393) |
1564816 ns/iter (± 35303) |
5.00 |
lotr_graph_window_100/num_nodes |
13 ns/iter (± 0) |
5 ns/iter (± 0) |
2.60 |
lotr_graph_window_100_materialise/materialize |
8126947 ns/iter (± 70841) |
1669150 ns/iter (± 10700) |
4.87 |
lotr_graph_window_10/has_node_existing |
136 ns/iter (± 9) |
62 ns/iter (± 11) |
2.19 |
lotr_graph_window_10_materialise/materialize |
3352201 ns/iter (± 11859) |
971980 ns/iter (± 4278) |
3.45 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
2082593 ns/iter (± 43974) |
334634 ns/iter (± 1287) |
6.22 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
141 ns/iter (± 15) |
62 ns/iter (± 14) |
2.27 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1254990 ns/iter (± 12027) |
230399 ns/iter (± 2617) |
5.45 |
lotr_graph_window_50_layered/num_edges_temporal |
142510 ns/iter (± 3171) |
70121 ns/iter (± 7586) |
2.03 |
lotr_graph_window_50_layered/has_node_existing |
379 ns/iter (± 19) |
129 ns/iter (± 12) |
2.94 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/graph_latest |
83826 ns/iter (± 1802) |
36649 ns/iter (± 916) |
2.29 |
lotr_graph_window_50_layered_materialise/materialize |
29053070 ns/iter (± 124750) |
3488825 ns/iter (± 24948) |
8.33 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
583663 ns/iter (± 7823) |
192686 ns/iter (± 1569) |
3.03 |
lotr_graph_persistent_window_50_layered/has_node_existing |
414 ns/iter (± 369) |
174 ns/iter (± 83) |
2.38 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/graph_latest |
130736 ns/iter (± 2631) |
57549 ns/iter (± 4809) |
2.27 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
50020293 ns/iter (± 462973) |
5298035 ns/iter (± 147912) |
9.44 |
This comment was automatically generated by workflow using github-action-benchmark.
…tifier ops with list-aware aggregates
…y>> and make is_active return PyExpr
…ctory + migrate PyEdgeFilter/PyExplodedEdgeFilter
…s; drop dead PyGraphFilter::new
…ath helpers from PyFilterExpr, ref
…o-dynamic-first pattern
…verrides, non-const RHS type check, list-aware aggregator gate
…Loop) to generic view_expr shape
…oop edge predicates with per-edge prop ops
…b method collisions on primitive EntityExpr types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.