Db v4 move graph folder#2624
Open
arienandalibi wants to merge 27 commits into
Open
Conversation
…icate DIRTY_PATH in raphtory-graphql/src/data.rs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 66ec85e | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
8044498 ns/iter (± 22649) |
1564816 ns/iter (± 35303) |
5.14 |
lotr_graph_window_100/num_nodes |
14 ns/iter (± 0) |
5 ns/iter (± 0) |
2.80 |
lotr_graph_window_100_materialise/materialize |
8117200 ns/iter (± 28653) |
1669150 ns/iter (± 10700) |
4.86 |
lotr_graph_window_10/has_node_existing |
143 ns/iter (± 11) |
62 ns/iter (± 11) |
2.31 |
lotr_graph_window_10_materialise/materialize |
3364370 ns/iter (± 40443) |
971980 ns/iter (± 4278) |
3.46 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
1983727 ns/iter (± 19785) |
334634 ns/iter (± 1287) |
5.93 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
144 ns/iter (± 9) |
62 ns/iter (± 14) |
2.32 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1209152 ns/iter (± 39718) |
230399 ns/iter (± 2617) |
5.25 |
lotr_graph_window_50_layered/num_edges_temporal |
153269 ns/iter (± 2944) |
70121 ns/iter (± 7586) |
2.19 |
lotr_graph_window_50_layered/has_node_existing |
393 ns/iter (± 24) |
129 ns/iter (± 12) |
3.05 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/graph_latest |
85086 ns/iter (± 1741) |
36649 ns/iter (± 916) |
2.32 |
lotr_graph_window_50_layered_materialise/materialize |
30637583 ns/iter (± 150709) |
3488825 ns/iter (± 24948) |
8.78 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
651111 ns/iter (± 9914) |
192686 ns/iter (± 1569) |
3.38 |
lotr_graph_persistent_window_50_layered/has_node_existing |
441 ns/iter (± 396) |
174 ns/iter (± 83) |
2.53 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
3627216 ns/iter (± 52321) |
1659940 ns/iter (± 19402) |
2.19 |
lotr_graph_persistent_window_50_layered/graph_latest |
127168 ns/iter (± 2015) |
57549 ns/iter (± 4809) |
2.21 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
54622411 ns/iter (± 502652) |
5298035 ns/iter (± 147912) |
10.31 |
This comment was automatically generated by workflow using github-action-benchmark.
ljeub-pometry
requested changes
Jun 10, 2026
… over. Now, we have many import errors because things from raphtory can't be imported (like GraphError)
…_v4_move_graph_folder
….rs file over. Now, we have many import errors because things from raphtory can't be imported (like GraphError)" This reverts commit 2cab13c.
…build the GraphMetadata in Raphtory
# Conflicts: # raphtory/src/db/graph/views/filter/model/degree_filter.rs
…ata to update metadata instead of previous refresh_disk_graph_metadata.
ljeub-pometry
requested changes
Jun 19, 2026
ljeub-pometry
left a comment
ljeub-pometry
left a comment
Collaborator
There was a problem hiding this comment.
the Drop implementation for storage should be gone, the metadata write can now be part of the flush in the disk storage
…o GraphStore::flush (in db4-storage). Gets the graph type from reading the .meta file. Checks to make sure the path hasn't changed.
… "io" feature in raphtory-api. Update write_metadata to take a Metadata (not GraphView) bc GraphView isn't available in raphtory-api. Update callsites to construct the Metadata. Add an error type in raphtory-api to avoid using GraphError.
… error types. Update InnerGraph to be ready (write_metadata doesn't take GraphView). replace_graph is now replace_graph_path and updates the metadata/removes the old dir. Encoding the new graph's data is handled separately in replace_graph_in_folder and stays in raphtory.
# Conflicts: # db4-storage/src/pages/mod.rs # raphtory-api/src/core/storage/graph_folder.rs
# Conflicts: # raphtory-api/src/core/storage/graph_folder.rs # raphtory-graphql/src/model/graph/meta_graph.rs # raphtory-graphql/src/paths.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move graph_folder.rs constants (directory and file names regarding exported graphs) out of the raphtory crate and into raphtory-api.
Why are the changes needed?
Following previous changes, we needed access to GRAPH_META_PATH in pometry-storage, where we can't import from raphtory.
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Tests still pass
Are there any further changes required?
No