Add basic voice rendering#3
Open
ywsang wants to merge 23 commits into
Open
Conversation
Wrap Stave and Voice in web components
justinfagnani
suggested changes
Jul 8, 2020
justinfagnani
left a comment
justinfagnani
left a comment
There was a problem hiding this comment.
Looks ince!
This is just an initial pass, mostly on vf-score, but with comments that can be applied to the other elements around class fields, attributes, and initialization in connectedCallback.
straversi
reviewed
Jul 8, 2020
justinfagnani
approved these changes
Aug 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add four components (
vf-score,vf-system,vf-stave, andvf-voice) that support rendering simple/basic voices. This PR limits the score to one system per score (essentially one measure) and doesn't have tuplets or beams.