feat(wait-movement-command): add movement command#772
Conversation
Menthx
force-pushed
the
562-wait-for-movement-command
branch
2 times, most recently
from
90168ea to
8563176
Compare
- Remove circular dependecies - Make export command file possible - Create folder to rearrange the flow - display the wait completion node
Menthx
force-pushed
the
562-wait-for-movement-command
branch
from
8563176 to
6bf1dbd
Compare
| "event_command_wait_move_completion": "Wait for move completion", | ||
| "event_command_wait_move_completion_select": "Waiting", | ||
| "event_command_wait_move_completion_select_all": "All event", | ||
| "event_command_wait_move_completion_select_some": "Wait spécifics events", |
There was a problem hiding this comment.
"specific events" au lieu de "spécific events" (l'accent et le s en trop), pareil dans tous les CSV hors-FR
| "event_command_wait_move_completion_select": "Waiting", | ||
| "event_command_wait_move_completion_select_all": "All event", | ||
| "event_command_wait_move_completion_select_some": "Wait spécifics events", | ||
| "event_command_wait_move_completion_multiselect_label": "Event to wait", |
There was a problem hiding this comment.
"Events" au lieu de "Event", pareil dans tous les CSV hors-FR
There was a problem hiding this comment.
Faudrait renommer le dossier dans lequel tu as mis ce fichier, waitCommand c'est pas la même commande que waitMovementCompletionCommand, ça va être confusant à l'avenir.
| import { COMMAND_CONNECTION_ID_VALIDATOR, EVENT_COMMAND_CONNECTION_VALIDATOR, EVENT_COMMAND_STUDIO_DATA_VALIDATOR } from '../globalCommand'; | ||
|
|
||
| export const EVENT_COMMAND_WAIT_MOVEMENT_COMPLETION_VALIDATOR = z.object({ | ||
| waitAllevent: z.boolean().default(false), |
There was a problem hiding this comment.
Plutôt "waitAllEvents", pour respecter le camelCase et le pluriel
| import type { StudioEventCommandCategory } from './category'; | ||
|
|
||
| export const COMMAND_ID_VALIDATOR = z.string().brand('CommandId'); | ||
| export type CommandId = z.infer<typeof COMMAND_ID_VALIDATOR>; |
There was a problem hiding this comment.
Tu as bougé les export de CommandId et ConnectionId mais tu n'as pas update les fichiers qui les importaient (ex: ShowMessageCommand, EventUtils, etc...)
| <Input name="timeout" label={t('event_editor_wait_move_completion_timeout')} labelLeft defaultValue={command.timeout} ref={timeoutRef} /> | ||
| </InputWithLeftLabelContainer> | ||
| <TimeoutInfo>{t('event_editor_wait_move_completion_timeout_info')}</TimeoutInfo> | ||
| </InputWithTopLabelContainer> |
There was a problem hiding this comment.
Le champ pour le timeout est pas aligné à droite comme sur figma, il manque aussi l'unité "s":
Studio:
Figma:
There was a problem hiding this comment.
Si la node est pas sélectionné quand je clique sur un select, il se ferme directement.
20260627-1301-34.8028800.mp4
Et si je vide les options du multi-select, en sortant ça revient à l'état précédent. Dans l'éditeur ça marche bien de faire ça.
20260627-1303-12.1092883.mp4
There was a problem hiding this comment.
Je peux fermer l'éditeur quand le multi-select n'a aucune option sélectionnée. Auquel cas ça revient à l'état précédent quand je re-ouvre l'éditeur.
2 participants
Thank you for your contribution to the Pokémon Studio repo.
Before submitting this PR into the develop branch, please make sure:
Description
Add a node command who can:
Option to wait for all events
Option to wait for specific events
Timeout option
Integration with movement commands
Tests to perform
I want events to wait for movements to complete
So that I can add some timing between event movements
Add the node associated, try to update it, save it, reload, and do the same with the editor.