Add dynamic endpoints to WebsocketAdapter#378
Draft
NeejWeej wants to merge 11 commits into
Draft
Conversation
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
2 times, most recently
from
November 3, 2024 22:25
3ed3981 to
2022cc9
Compare
NeejWeej
changed the title
NeejWeej
changed the title
NeejWeej
changed the title
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 13, 2024 15:44
fb9fdaa to
a3447ec
Compare
Signed-off-by: Nijat K <[email protected]>
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 25, 2024 06:11
c925d63 to
fcea900
Compare
NeejWeej
marked this pull request as ready for review
November 25, 2024 07:45
NeejWeej
requested review from
AdamGlustein,
alexddobkin,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
November 25, 2024 07:45
NeejWeej
changed the title
Signed-off-by: Nijat K <[email protected]>
timkpaine
reviewed
Nov 25, 2024
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
5 times, most recently
from
November 26, 2024 08:01
f1af757 to
c98eef3
Compare
Signed-off-by: Nijat K <[email protected]>
Signed-off-by: Nijat K <[email protected]>
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
2 times, most recently
from
November 29, 2024 03:31
a91f650 to
c6457bd
Compare
NeejWeej
commented
Nov 29, 2024
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 29, 2024 03:49
c6457bd to
29db774
Compare
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 29, 2024 05:18
29db774 to
4d64618
Compare
Signed-off-by: Nijat K <[email protected]>
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 29, 2024 06:36
4d64618 to
639c5aa
Compare
robambalu
reviewed
Nov 29, 2024
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
December 3, 2024 22:48
e7b2131 to
dbb1bb4
Compare
Signed-off-by: Nijat K <[email protected]>
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
December 3, 2024 23:10
dbb1bb4 to
8ca822c
Compare
timkpaine
added
type: enhancement
wrieg123
reviewed
Dec 4, 2024
wrieg123
reviewed
Dec 4, 2024
wrieg123
reviewed
Dec 8, 2024
wrieg123
reviewed
Dec 8, 2024
wrieg123
reviewed
Dec 8, 2024
wrieg123
previously approved these changes
Dec 8, 2024
Signed-off-by: Nijat K <[email protected]>
timkpaine
marked this pull request as draft
March 1, 2025 00:32
Member
|
moving back to draft for now, we have some ongoing conversations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
We basically have bi-directional maps from each adapter (subscribe/send) to the endpoints we have.