Skip to content

Updated Evaluate Options and Settings - #363

Open
a3person wants to merge 1 commit into
PoE-Overlay-Community:masterfrom
a3person:evaluateInstantBuyout
Open

Updated Evaluate Options and Settings #363
a3person wants to merge 1 commit into
PoE-Overlay-Community:masterfrom
a3person:evaluateInstantBuyout

Conversation

@a3person

@a3person a3person commented Nov 25, 2025

Copy link
Copy Markdown

Description

For Issue #362 so we can evaluate items using Instant Buyout prices

  • Replaced 'online' toggle with 'trade type' selection.
  • Update related interfaces and services
  • Changed default to instant buyout only

Replication Steps

Evaluate something and observe its instant buyout only

Screenshots/Video

Showing Evaluate Options

NVIDIA_Overlay_2025-11-23_19-28-25.mp4

Showing Evaluate Settings

NVIDIA_Overlay_2025-11-23_19-27-35.mp4

How Has This Been Tested?

  • ran npm run ng:lint
  • ran npm run format
    Yes, but it formatted more than just git changed so I aborted
  • ran npm run ng:test
  • added unit tests
  • manually tested

I ran npm run ng:test 88/90
ItemPricePredictionService should return items FAILED
UserSettingsFormComponent should create FAILED

But it also failed on master branch so idk

- Update related interfaces and services
- Changed default to instant buyout only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant