Skip to content

WIP: Add user configurable keybind to restart the overlay - #149

Open
Gee19 wants to merge 1 commit into
PoE-Overlay-Community:masterfrom
Gee19:feature/user_configurable_restart_keybind
Open

WIP: Add user configurable keybind to restart the overlay#149
Gee19 wants to merge 1 commit into
PoE-Overlay-Community:masterfrom
Gee19:feature/user_configurable_restart_keybind

Conversation

@Gee19

@Gee19 Gee19 commented Oct 1, 2020

Copy link
Copy Markdown

Description

This PR adds a user configurable keybind to restart the overlay.

This was something I was looking for (as well as a few other small things like my comment in #85) so why not give it a shot and get more familiar with the repo at the same time. Apologies if I am missing anything obvious, I am open to feedback from anyone.

Bonus:

  • Show keybind in context menu when clicking system icon

How Has This Been Tested?

  • ran npm run ng:lint
  • ran npm run format
  • ran npm run ng:test
  • added unit tests
  • manually tested

Resources:
https://www.electronjs.org/docs/api/app#apprelaunchoptions

@WhiteFang5 WhiteFang5 self-assigned this Oct 3, 2020
@WhiteFang5
WhiteFang5 self-requested a review October 3, 2020 08:08
@WhiteFang5 WhiteFang5 removed their assignment Oct 3, 2020
Comment thread src/app/layout/page/overlay/overlay.component.ts Outdated
@WhiteFang5

Copy link
Copy Markdown
Member

The Show keybind in context menu when clicking system icon? todo might be interesting, and could also be applied to other context menu items (such as quit and settings). I don't deem this necessary to accept the PR though.

However, there is one other thing I do deem necessary and that's the UI addition to allow users to change this keybind and/or properly enable/disable it. (Take a look at user-settings-form.component.html for this)

@Gee19
Gee19 force-pushed the feature/user_configurable_restart_keybind branch from 0c305bf to 3ff72d2 Compare October 4, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants