WIP: Dev trade chat module - #14
Draft
versedi wants to merge 2 commits into
Draft
Conversation
versedi
marked this pull request as draft
June 12, 2020 01:30
versedi
commented
Jun 12, 2020
| private readonly snackbar: SnackBarService) { | ||
| } | ||
|
|
||
| public open(external: boolean): Observable<void> { |
Author
There was a problem hiding this comment.
completely to rewrite ctrl+c just so UI works
versedi
commented
Jun 12, 2020
| public run(feature: string, _: TradeUserSettings): void { | ||
| switch (feature) { | ||
| case 'chat-read-client-file': | ||
| this.chat.open(feature === 'chat-read-client-file').subscribe(); |
Author
There was a problem hiding this comment.
we need to trigger the read file service here
versedi
commented
Jun 12, 2020
| this.chat.open(feature === 'chat-read-client-file').subscribe(); | ||
| break; | ||
| case 'chat-client-file-path': | ||
| this.chat.open(feature === 'chat-client-file-path').subscribe(); |
Author
There was a problem hiding this comment.
add validation if file exists, if it does start reading in file service
versedi
commented
Jun 12, 2020
| @@ -0,0 +1,3 @@ | |||
| body { | |||
Author
There was a problem hiding this comment.
to remove import or clear the file, unnecessary
versedi
commented
Jun 12, 2020
| }; | ||
| } | ||
|
|
||
| public getFeatures(settings: TradeUserSettings): Feature[] { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs:
TODO: