fix(oracle): reject impossible result times#143
Draft
rndrntwrk wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the DuelOutcomeOracle result-timeline validation finding from the contract audit.
proposeResult()andreproposeResult()now reject impossible result timestamps:betCloseTsduelStartTsblock.timestampThe fix is intentionally local to
DuelOutcomeOracle; affected tests were updated to resolve duels at a valid result timestamp instead of relying on futureduelEndTsvalues.Security Impact
Before this change, an authorized reporter could submit a result before the duel was scheduled to start, or with a future result timestamp. That could make downstream settlement consumers treat an impossible timeline as oracle truth.
After this change, oracle result submission fails closed unless the reported result time is inside the valid historical duel window.
Validation
test_proposeRejectsResultBeforeDuelStarttest_proposeRejectsFutureResultEndtest_reproposeRejectsResultBeforeDuelStarttest_reproposeRejectsFutureResultEndforge test --match-path test/OracleFinality.t.sol-> 27 passedforge test-> 178 passed, 0 failedforge build-> passgit diff --check-> passforge fmt --checkremains noisy on pre-existing project style drift, so this PR does not apply broad formatting churn.Rollout
Draft PR for review. This branch targets
main; the same commit is intended to be replayed intoenoomian/stagingfor staging deployment/testing without makingenoomian/stagingthe long-term merge target.