fix(amm): settle lvr markets from duel oracle#139
Draft
rndrntwrk wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the LVR manual-settlement authority gap found during the contract audit.
Before this patch, a manual proposal could move an
LvrMarketfromPENDINGtoRESOLVEDthroughsettleMarket()after the dispute window without consultingDuelOutcomeOracle. That made the manual proposer path an alternate settlement authority and could block the oracle-backed outcome from ever being applied.This patch keeps the existing manual proposal and dispute-window mechanics, but final settlement now always routes through the same oracle-backed settlement path used by
settleFromOracle().Security Impact
settleMarket()no longer resolves from the proposer-provided outcome directly.settleMarket()now requires the duel oracle to be resolved before the market can resolve.settleFromOracle()behavior is preserved through a shared private settlement helper.Verification
env FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/LvrMarket.t.sol --match-test 'test_(ManualSettlementCannotResolveWithoutOracleResult|SettleMarketUsesOracleOutcomeAfterManualProposal)'-> 2 passed, 0 failedenv FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/LvrMarket.t.sol-> 34 passed, 0 failedgit diff --check-> passStaging Policy
This PR targets
mainand is intentionally draft while review is pending. The same patch is replayed intoenoomian/stagingfor staging deployment and testing, but this effective PR remains open as the merge vehicle.