fix(playlist): enable Save when all playlists deselected for single song#2562
Open
fiveclankers wants to merge 1 commit into
Open
fix(playlist): enable Save when all playlists deselected for single song#2562fiveclankers wants to merge 1 commit into
fiveclankers wants to merge 1 commit into
Conversation
Fixes PixelPlayerHQ#2553 The Save FAB in PlaylistBottomSheet was gated on isAnyPlaylistSelected, which meant that when a user opened the sheet for a song already in a playlist and unchecked all playlists, the button went grey and was non-functional — making it impossible to remove a song from its last playlist via this UI. Fix: replace isAnyPlaylistSelected with hasSelectionChanged, which captures the initial membership snapshot (initialSelection) once on sheet open and enables Save whenever the current state differs from it. Passing an empty list to addOrRemoveSongFromPlaylists is already handled correctly by the repository layer — it removes the song from every playlist that contains it. This also fixes a secondary issue: the Save button was incorrectly enabled after checking then unchecking a box (back to original state), because the old logic only checked whether anything was ticked, not whether the state had actually changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2553
The Save FAB in PlaylistBottomSheet was gated on isAnyPlaylistSelected, which meant that when a user opened the sheet for a song already in a playlist and unchecked all playlists, the button went grey and was non-functional ,making it impossible to remove a song from its last playlist via this UI.
Fix: replace isAnyPlaylistSelected with hasSelectionChanged, which captures the initial membership snapshot (initialSelection) once on sheet open and enables Save whenever the current state differs from it. Passing an empty list to addOrRemoveSongFromPlaylists is already handled correctly by the repository layer. it removes the song from every playlist that contains it.
This also fixes a secondary issue: the Save button was incorrectly enabled after checking then unchecking a box (back to original state), because the old logic only checked whether anything was ticked, not whether the state had actually changed.