Skip to content

fix: report unsupported server version at startup instead of misleading per-message errors #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UltraGameCoder wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: report unsupported server version at startup instead of misleading per-message errors #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99650ca
Report unsupported server version at startup
UltraGameCoder Jul 18, 2026
d539337
fix: include detected server version in unsupported-version logs
UltraGameCoder Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/main/java/me/pikamug/localelib/LocaleManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public LocaleManager() {
isPost1dot18 = true;
}
final String packageName = Bukkit.getServer().getClass().getPackage().getName();
final String bukkitVersion = Bukkit.getBukkitVersion();
try {
if (packageName.equals("org.bukkit.craftbukkit")) {
// Bukkit version is 1.20.5+
Expand All @@ -92,7 +93,13 @@ public LocaleManager() {
}
}
} catch (final ClassNotFoundException e) {
e.printStackTrace();
Bukkit.getLogger().severe("[LocaleLib] Unable to resolve NMS/CraftBukkit classes for this server "
+ "version (" + bukkitVersion + "): " + e.getMessage());
}
if (!oldVersion && (craftMagicNumbers == null || itemClazz == null)) {
Bukkit.getLogger().severe("[LocaleLib] This server version (" + bukkitVersion + ") does not appear to "
+ "be supported. Material name translation will not work; entity and enchantment translation "
+ "are unaffected.");
}
try {
englishTranslations = LocaleKeys.loadTranslations();
Expand Down Expand Up @@ -446,6 +453,11 @@ public String queryMaterial(final Material material, final short durability, fin
if (material.isBlock() && material.createBlockData() instanceof Ageable) {
matKey = "block.minecraft." + material.name().toLowerCase();
} else {
if (craftMagicNumbers == null || itemClazz == null) {
throw new IllegalArgumentException("[LocaleLib] Cannot query material '" + material.name()
+ "': NMS/CraftBukkit classes were not resolved for this server version ("
+ Bukkit.getBukkitVersion() + ") at startup.");
}
try {
final Method itemMethod = craftMagicNumbers.getDeclaredMethod("getItem", material.getClass());
itemMethod.setAccessible(true);
Expand Down