Skip to content

Improve factory_sim sim and 3D viewer visuals#712

Open
davetcoleman wants to merge 1 commit into
mainfrom
improve/factory-sim-visuals
Open

Improve factory_sim sim and 3D viewer visuals#712
davetcoleman wants to merge 1 commit into
mainfrom
improve/factory-sim-visuals

Conversation

@davetcoleman

Copy link
Copy Markdown
Member

Problem

factory_sim rendered with several flat-gray surfaces and a dated backdrop. The arm pedestal (the block the Fanuc sits on, plus its tool-holder tabs) had no material in either render path, so it showed as MuJoCo's default gray in the sim and flat white in the web 3D viewer. The scene also lacked basic render-quality settings.

Changes

MuJoCo sim (scene.xml):

  • Removed the gradient skybox so the background is a plain backdrop.
  • Switched the floor from a flat brown ground to a blue checker tile.
  • Added render-quality settings: offsamples="4" (MSAA), shadowsize="4096", and map haze="0.1". Pure render settings — no physics effect.
  • Added a pedestal_metal material (dark metal) and applied it to the 5 pedestal geoms.

Web 3D viewer (picknik_fanuc.xacro):

  • Defined a matching pedestal_metal material and referenced it on the 5 pedestal visuals, so the viewer renders the pedestal consistently with the sim.

Scope / why

  • Visual-only. No collision geometry, masses, joints, or contact parameters were touched.
  • The suction_tool_tip geom flagged by analysis is class="collision", so it was deliberately left alone.
  • The Fanuc arm links and bowls already carry their own colors and were not modified.
  • The two render paths are independent (MuJoCo vs. Three.js); the pedestal color is duplicated across both by necessity, kept identical (0.30 0.32 0.35).

Verification

  • Analyzer flat-render-risk dropped to 0 in both paths (excluding the intentional collision-geom exclusion).
  • xacro expands cleanly; both files are well-formed XML.
  • Visual confirmation in the running sim / viewer is pending.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@davetcoleman, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 21 minutes and 4 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b2d050c3-308d-4288-baa2-c5936946aaad

📥 Commits

Reviewing files that changed from the base of the PR and between 0c6dd67 and b70a298.

📒 Files selected for processing (2)
  • src/factory_sim/description/picknik_fanuc.xacro
  • src/factory_sim/description/scene.xml

Comment @coderabbitai help to get the list of available commands and usage tips.

MuJoCo scene: remove gradient skybox, switch floor to a blue checker tile, add anti-aliasing/shadow render-quality settings, and color the arm pedestal with a dark-metal material. URDF: give the pedestal the matching material so the web 3D viewer renders it consistently.
@davetcoleman davetcoleman force-pushed the improve/factory-sim-visuals branch from 9a76ef8 to b70a298 Compare June 14, 2026 04:31
@davetcoleman davetcoleman marked this pull request as ready for review June 14, 2026 04:31
@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant