Improve factory_sim sim and 3D viewer visuals#712
Conversation
|
Warning Review limit reached
More reviews will be available in 21 minutes and 4 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
MuJoCo scene: remove gradient skybox, switch floor to a blue checker tile, add anti-aliasing/shadow render-quality settings, and color the arm pedestal with a dark-metal material. URDF: give the pedestal the matching material so the web 3D viewer renders it consistently.
9a76ef8 to
b70a298
Compare
|
|
Problem
factory_simrendered with several flat-gray surfaces and a dated backdrop. The arm pedestal (the block the Fanuc sits on, plus its tool-holder tabs) had no material in either render path, so it showed as MuJoCo's default gray in the sim and flat white in the web 3D viewer. The scene also lacked basic render-quality settings.Changes
MuJoCo sim (
scene.xml):offsamples="4"(MSAA),shadowsize="4096", andmap haze="0.1". Pure render settings — no physics effect.pedestal_metalmaterial (dark metal) and applied it to the 5 pedestal geoms.Web 3D viewer (
picknik_fanuc.xacro):pedestal_metalmaterial and referenced it on the 5 pedestal visuals, so the viewer renders the pedestal consistently with the sim.Scope / why
suction_tool_tipgeom flagged by analysis isclass="collision", so it was deliberately left alone.0.30 0.32 0.35).Verification
xacroexpands cleanly; both files are well-formed XML.