fix(kinova_site): camera streaming, USB split, and pstop recovery#703
Open
suchkristenwow wants to merge 1 commit into
Open
fix(kinova_site): camera streaming, USB split, and pstop recovery#703suchkristenwow wants to merge 1 commit into
suchkristenwow wants to merge 1 commit into
Conversation
- config.yaml: keep joint_trajectory_controller active at startup so protective-stop recovery leaves a joint controller running; otherwise the arm settles in ARMSTATE_SERVOING_READY and the kortex driver re-reports RECOVERABLE_FAULT right after a successful reset. - ros2_control.yaml: raise JTAC path/goal tolerances to 0.20 rad so a real arm tracking a teleop path doesn't trip writeToleranceViolation (which aborts ros2_control_node via the fmt/spdlog ABI bug). - cameras.launch.xml: bump wrist-camera pub rate 6->30 Hz to match the ~30 Hz producer and keep the appsink FIFO drained (removes ~130-170 ms standing lag). - zed_camera.launch.xml: drop ZED 2i to VGA (1344x376) so two cameras fit the shared USB controller bandwidth. - robot_drivers_to_persist.launch.py: move scene_camera and scene_camera_2 onto separate USB controllers and delay scene_camera_2 by 40s to clear the wrist-camera STREAMON startup race. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Site-config fixes for the real Kinova Gen3 deployment, covering protective-stop recovery, JTAC tolerances, and multi-camera streaming reliability.
joint_trajectory_controlleractive at startup. Protective-stop recovery deactivates everything and reactivates the default-active set; without a joint controller in that set the arm settles inARMSTATE_SERVOING_READY, which the kortex driver'sread()reports asin_fault_, so the arm re-reportsRECOVERABLE_FAULTimmediately after a successful reset.default_path_tolerance/default_goal_toleranceto 0.20 rad. A real arm tracking a teleop-generated path easily exceeds the 0.05 rad default; any violation funnels throughwriteToleranceViolation, which currently abortsros2_control_node(fmt/spdlog ABI clash). Keep generous until that upstream bug is fixed.scene_cameraandscene_camera_2on separate USB controllers, and delayscene_camera_2by 40s to clear the wrist-cameraVIDIOC_STREAMONstartup race (the wrist cam retries stream-start for ~34s; bringing scene_camera_2 up mid-storm leaves it advertising topics but publishing zero frames).Test plan
🤖 Generated with Claude Code