PressTarget#129
Conversation
marchant
left a comment
marchant
left a comment
There was a problem hiding this comment.
More work needed to look at what the spec does to assess wether it's assessing behavior now in ActionTarget, or still in Button, and eventually split between the relevant's specs if it's a bit of both.
| describe("disabled property", function () { | ||
| var anActionTarget; | ||
| beforeEach(function () { | ||
| anActionTarget = new Button(); |
There was a problem hiding this comment.
This should not be Button anymore if it stays here, or it should move back to button's spec.
You need to look at what the spec does to assess wether it's assessing behavior now in ActionTarget, or still in Button, and eventually split if it's a bit of both.
| describe("active target", function () { | ||
| var anActionTarget, anElement; | ||
| beforeEach(function () { | ||
| anActionTarget = new Button(); |
There was a problem hiding this comment.
This should not be Button anymore if it stays here, or it should move back to button's spec.
You need to look at what the spec does to assess wether it's assessing behavior now in ActionTarget, or still in Button, and eventually split if it's a bit of both.
|
|
||
| describe("converter", function () { | ||
| beforeEach(function () { | ||
| anActionTarget = new Button(); |
There was a problem hiding this comment.
This should not be Button anymore if it stays here, or it should move back to button's spec.
You need to look at what the spec does to assess wether it's assessing behavior now in ActionTarget, or still in Button, and eventually split if it's a bit of both.
| anElement = MockDOM.element(); | ||
| }); | ||
| it("should set tabindex if needed", function () { | ||
| anElement.tagName = "DIV"; |
There was a problem hiding this comment.
This should not be Button anymore if it stays here, or it should move back to button's spec.
You need to look at what the spec does to assess wether it's assessing behavior now in ActionTarget, or still in Button, and eventually split if it's a bit of both.
| describe("events", function () { | ||
| var anActionTarget, anElement, listener; | ||
| beforeEach(function () { | ||
| anActionTarget = new Button(); |
There was a problem hiding this comment.
This should not be Button anymore if it stays here, or it should move back to button's spec.
You need to look at what the spec does to assess wether it's assessing behavior now in ActionTarget, or still in Button, and eventually split if it's a bit of both.
| }); | ||
| describe("objectDescriptor", function () { | ||
| it("can be created", function (done) { | ||
| var objectDescriptorPromise = Button.objectDescriptor; |
There was a problem hiding this comment.
This should not be Button anymore if it stays here, or it should move back to button's spec.
You need to look at what the spec does to assess wether it's assessing behavior now in ActionTarget, or still in Button, and eventually split if it's a bit of both.
3 participants
Adds ui/press-target.mod, a basic component wrapper to add a press composer and limited press related functionality to a component