This repository was archived by the owner on Aug 19, 2021. It is now read-only.
PMM-8459 Ability to disable updates.#228
Open
JiriCtvrtka wants to merge 6 commits into
Open
Conversation
9 tasks
askomorokhov
approved these changes
Jul 29, 2021
percona-csalguero
approved these changes
Aug 4, 2021
BupycHuk
suggested changes
Aug 4, 2021
BupycHuk
left a comment
BupycHuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but let's change order.
Comment on lines
+58
to
+70
| res, err := serverClient.Default.Server.ChangeSettings(&server.ChangeSettingsParams{ | ||
| Body: server.ChangeSettingsBody{ | ||
| EnableUpdates: true, | ||
| }, | ||
| Context: pmmapitests.Context, | ||
| }) | ||
| require.NoError(t, err) | ||
| assert.False(t, res.Payload.Settings.UpdatesDisabled) | ||
| assert.Empty(t, err) | ||
|
|
||
| resg, err := serverClient.Default.Server.GetSettings(nil) | ||
| require.NoError(t, err) | ||
| assert.False(t, resg.Payload.Settings.UpdatesDisabled) |
Contributor
There was a problem hiding this comment.
let's first disable updates and then enable updates.
|
|
||
| res, err = serverClient.Default.Server.ChangeSettings(&server.ChangeSettingsParams{ | ||
| Body: server.ChangeSettingsBody{ | ||
| DisableUpdates: false, |
Contributor
There was a problem hiding this comment.
it does nothing actually.
Can we check that DisableUpdates: true disables updates?
BupycHuk
suggested changes
Aug 16, 2021
| Context: pmmapitests.Context, | ||
| }) | ||
| require.NoError(t, err) | ||
| assert.False(t, res.Payload.Settings.UpdatesDisabled) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.