fix(voices): distinguishing subtitles for identically-named catalog rows (#474)#478
Merged
Conversation
…title (#474) The pi catalog serves two distinct voices both named "Paola" (classic + eleven_v3); only the v3 variant carries a server description, so the settings catalog showed two identical bare rows. Rows without a description now fall back to a language-coverage subtitle ("Speaks N languages") built from the /voices `languages` field, which is exactly what separates the twins (33 vs 75 languages) and is useful copy on any description-less row. Closes #474 Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_012DZR4Vp9B1RiKVrkfYiM1o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Founder tasting feedback on Patch A (#470): "Paola appears in the list for Pi twice." The live pi
/voicespayload genuinely contains two distinct Paolas — classic (ig1Te…, 33 languages, 1000 credits/1k, no description) andpaola-v3(eleven_v3 model, 75 languages, 2000 credits/1k, with a description). The settings catalog rendered subtitles only fromdescription, so the classic row was bare and the two rows were indistinguishable.What
voiceSpeaksNLanguages, new en key with a$count$placeholder). Language coverage is exactly what separates the twins, and it's honest, useful copy on any description-less row (Joey gets it too).SpeechSynthesisVoiceRemotegains the optionallanguages?: string[]field the server already sends.sibling_id) remains the planned/voicesmanifest work in saypi-api (design doc §5).Tests (fail-first)
Two new cases in
voices-controller.spec.tsx: twin-name catalog renders distinct, non-empty subtitles (failed before — classic Paola's subtitle was empty); a voice with neither description nor language data renders no subtitle span. Fullnpm testgate green.Closes #474
🤖 Generated with Claude Code
https://claude.ai/code/session_012DZR4Vp9B1RiKVrkfYiM1o