remove import of ProfilesLibrary. - #43
Open
stiesssh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preamble
sorry for the short notice PR, i only noticed this problem, when i attempted to run the headless slingshot with the
bug-fix-scaling-in-transformationbranch.once upon a time, i apparently fixed this locally an the forgot about it.
Problem
When running slingshot headless in the context of the MENTOR project, i end up with an compilation error for the transformation files:
I could not recreate the error when running slingshot normally, i.e. with UI.
Also i did not manage to run slingshot outside the MENTOR context in headless mode (due to fucked up UI dependencies in experiment automation), i.e. i could not ascertain, that this error is a general problem when running headless.
Solution
remove the line
import org.palladiosimulator.architecturaltemplates.catalog.black.ProfilesLibrary;and delete the unused transformationLoadbalancing.qvto, which actually used the profiles library.Misc
My assumption is, that this error appears in headless mode, because i'm running headless with the bare minimum of dependencies, especially removing all UI related dependencies. Thus, when running with UI, the dependency to the profiles library is fullfilled, while it is missing in headless-mode, resulting in that compilation error.
This is only my personal assumption though, i got no proof.
@klinakuf if you accept this PR, please merge it on your own, i probably wont be able to do it.