Fix sdist build under setuptools >= 82 (pkg_resources removed)#183
Open
sethc555 wants to merge 1 commit into
Open
Fix sdist build under setuptools >= 82 (pkg_resources removed)#183sethc555 wants to merge 1 commit into
sethc555 wants to merge 1 commit into
Conversation
…>=82) setuptools 82.0.0 (2026-02-08) removed pkg_resources, so building this project's sdist in a default isolated build environment fails with ModuleNotFoundError: No module named 'pkg_resources'. Drop the parse_version-based setuptools>=36.2 assert; any setuptools new enough to lack pkg_resources satisfies it vacuously. Verified: the patched sdist builds a wheel with setuptools 82 in a clean python:3.12 container; the unpatched one does not. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools 82.0.0 (2026-02-08) removed
pkg_resources. Because pip's default isolated build installs the latest setuptools, installing sql_formatter from sdist now fails:This drops the parse_version-based setuptools>=36.2 assert — any setuptools new enough to lack pkg_resources satisfies it vacuously.
Verified: with this patch the sdist builds a wheel against setuptools 82 in a clean python:3.12 container; without it, it does not.
Found while scanning the top-5000 PyPI packages for breakage from the setuptools 82 removals — happy to adjust the patch however you prefer.