Conversation
Collaborator
|
Nice @danielhollas, I like it! Fancy, as always. Once you finish that, should we release v1.0.3 to resolve issue #65? |
danielhollas
marked this pull request as ready for review
April 20, 2026 07:47
Collaborator
Author
|
@JanosJiri this is ready, thanks! |
JanosJiri
approved these changes
Apr 27, 2026
JanosJiri
left a comment
JanosJiri
left a comment
Collaborator
There was a problem hiding this comment.
Nice work @danielhollas. All looks good to me, thank you!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds typing throughout the code, and
tytype checker (from the same people who built ruff) to check the types in CI. This should make future changes to the code safer.(had this branch lying around for a while)