Skip to content

Remove shellcheck pre-commit hook#254

Merged
danielhollas merged 1 commit into
masterfrom
remove-shellcheck
Jul 6, 2026
Merged

Remove shellcheck pre-commit hook#254
danielhollas merged 1 commit into
masterfrom
remove-shellcheck

Conversation

@danielhollas

Copy link
Copy Markdown
Contributor

Unfortunately, shellcheck (BASH linter) pre-commit hook requires Docker for installation, which many people will not have. Let's remove it for now. One can still install shellcheck using e.g. apt and run it manually.

@danielhollas
danielhollas requested a review from JanosJiri July 6, 2026 14:05
@danielhollas
danielhollas enabled auto-merge (squash) July 6, 2026 14:09
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.00%. Comparing base (06ac5cd) to head (0108a1a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files          47       47           
  Lines        6633     6633           
  Branches      768      768           
=======================================
  Hits         5572     5572           
  Misses        865      865           
  Partials      196      196           
Flag Coverage Δ
unittests 18.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JanosJiri JanosJiri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a pitty..

@danielhollas
danielhollas merged commit 4a5aaa0 into master Jul 6, 2026
17 checks passed
@danielhollas
danielhollas deleted the remove-shellcheck branch July 6, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants