Skip to content

Decoupling of temp0 and temp keywords#251

Open
JanPolena wants to merge 5 commits into
masterfrom
temp0
Open

Decoupling of temp0 and temp keywords#251
JanPolena wants to merge 5 commits into
masterfrom
temp0

Conversation

@JanPolena

@JanPolena JanPolena commented Jun 22, 2026

Copy link
Copy Markdown

Setting the temp0 keyword within the input.in file is now mandatory, unless the initial velocities are provided either from an external file or by restarting the calculation. In other cases, the user gets an error.

As such, I also had to change the test files so that they contain the temp0 keyword.

In addition, I have created a new test in the INIT directory to test forgetting of the temp0 keyword in input.in when initial velocities are not provided.

@JanPolena JanPolena requested a review from danielhollas June 22, 2026 15:26
@JanPolena JanPolena self-assigned this Jun 22, 2026
@JanPolena JanPolena linked an issue Jun 22, 2026 that may be closed by this pull request
@JanPolena JanPolena added this to the v2.0 milestone Jun 22, 2026
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.01%. Comparing base (2572f92) to head (11edbce).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   84.00%   84.01%           
=======================================
  Files          47       47           
  Lines        6633     6637    +4     
  Branches      768      768           
=======================================
+ Hits         5572     5576    +4     
  Misses        865      865           
  Partials      196      196           
Flag Coverage Δ
unittests 18.28% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/init.F90 82.73% <100.00%> (+0.10%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JanPolena JanPolena removed the request for review from danielhollas June 22, 2026 15:35
@JanPolena JanPolena marked this pull request as draft June 22, 2026 15:36
@JanPolena JanPolena marked this pull request as ready for review June 23, 2026 09:56
@JanPolena JanPolena requested a review from danielhollas June 23, 2026 09:56
Copilot AI requested a review from JanosJiri June 29, 2026 12:26
@danielhollas

Copy link
Copy Markdown
Contributor

Thanks for the PR and sorry for the delay in review. I will get to it next week, but on a quick skim this looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decouple temp and temp0 keywords

2 participants