Skip to content

MACE interface, vol. 2#242

Open
danielhollas wants to merge 73 commits into
masterfrom
dh-mace
Open

MACE interface, vol. 2#242
danielhollas wants to merge 73 commits into
masterfrom
dh-mace

Conversation

@danielhollas

@danielhollas danielhollas commented May 30, 2026

Copy link
Copy Markdown
Contributor

This is a continuation from #224, with the following changes

  • remove &mace section from the abin input file, instead the path to the model and other configuration is passed via command line parameter to mace_server.py. This is specified at the top of utils/run.mace_abin.sh
  • Fix coordinates received from ABIN (without this the interface was simply not working)
  • Use MACECalculator instead of calling pytorch directly
  • Fix float32 evaluation
  • removed install_mace.sh and the MACE-OFF model file
  • test mace_server.py in MACE test directly
  • lot's of error-handling improvements
  • add tests for error paths

TODO:

  • Test run.mace_abin.sh
  • Let Veronika test everything
  • Check size of incoming coordinates from ABIN in mace_server.py
  • Use logging module?

@danielhollas danielhollas requested review from FelyCZ and JanosJiri July 8, 2026 18:42
@danielhollas

Copy link
Copy Markdown
Contributor Author

Okay, I think this is mostly ready now for merging! We'll do some internal testing. @FelyCZ would be great if you could have a look. I summarized the changes I made in the PR description.

@JanosJiri up to you how much you want to review this. Perhaps at least the README files and mace_server.py for clarity. I'll ask people here for review as well.

@JanosJiri JanosJiri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danielhollas, I'm sorry but I struggle with time now and I can't make a useful review in a short time. I checked README.md though and it looks clean and understandable to me. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants