MACE interface, vol. 2#242
Open
danielhollas wants to merge 73 commits into
Open
Conversation
modified: sample_inputs/input.in.mace modified: src/mace_mpi_api.F90
new file: interfaces/MACE/README.md
Contributor
Author
|
Okay, I think this is mostly ready now for merging! We'll do some internal testing. @FelyCZ would be great if you could have a look. I summarized the changes I made in the PR description. @JanosJiri up to you how much you want to review this. Perhaps at least the README files and |
JanosJiri
reviewed
Jul 10, 2026
JanosJiri
left a comment
Contributor
There was a problem hiding this comment.
Hi @danielhollas, I'm sorry but I struggle with time now and I can't make a useful review in a short time. I checked README.md though and it looks clean and understandable to me. Sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation from #224, with the following changes
&macesection from the abin input file, instead the path to the model and other configuration is passed via command line parameter tomace_server.py. This is specified at the top ofutils/run.mace_abin.shinstall_mace.shand the MACE-OFF model filemace_server.pyin MACE test directlyTODO: