fix(catalog): handle decode errors in load_manifest in generate-extensions-catalog.py - #2622
Open
mohitchauhan221 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/scripts/generate-extensions-catalog.py,load_manifest()opens service extension manifest YAML files viamanifest_path.read_text(encoding="utf-8"). If a manifest file contains non-UTF-8 bytes or decode errors occur during parsing, aUnicodeDecodeErrororValueErrorcould escape the exception handler block.Fix
Include
UnicodeDecodeErrorandValueErrorin the exception handler block inload_manifest(), logging a warning to stderr and returningNonegracefully.Verification
Verified syntax with
python3 -m py_compile ods/scripts/generate-extensions-catalog.py.git diff --checkpassed cleanly.