fix: keep announced destination exits actionable#119
Merged
Conversation
Orinks
marked this pull request as ready for review
July 26, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Fixes #113.
Destination-exit speech and X eligibility both recalculated the same speed-dependent approach window. If the truck slowed while the callout was speaking, that window could contract before the player reacted, so the game announced an actionable destination exit and then answered "No exit coming up."
This change gives the exact announced destination exit a keyed 25-second real-time response window. The keyed destination takes priority over nearer optional stops, remains valid only while it is still ahead, and expires cleanly so a closer callout can be announced later. Successful input also stops unfinished event speech before the signaling confirmation. Existing automatic-speed-control behavior is unchanged: the automatic ramp target remains 40 mph, the hard ramp limit remains 45 mph, and control releases on ramp entry.
What players or maintainers will notice
Players using Standard or Fast trip pacing can finish hearing a destination-exit callout and press X without the exit disappearing because their speed changed. Expired, mismatched, and already-passed exits still cannot be armed.
The player manual now correctly distinguishes the 40 mph automatic target from the 45 mph ramp limit.
Tests and checks run
MemoryError; the serial full rerun passed.git diff --check, and the release-note gate.Accessibility impact
Accessibility Agents lead plus ARIA, keyboard, headings/text, forms/input, live-region, contrast, modal, links, and tables specialists reviewed the final delta and returned SHIP with no open findings. Keyboard X and controller D-pad Down continue through the same exit action path. Spoken confirmation replaces the unfinished event callout instead of overlapping it.
Changelog
## UnreleasedinCHANGELOG.md, written in plain player language and matching the style of the existing entries.[skip changelog].